From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-10.5 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6E8C61F428 for ; Fri, 17 Mar 2023 16:29:11 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=FEzoG3T3; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjCQQ2v (ORCPT ); Fri, 17 Mar 2023 12:28:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbjCQQ2s (ORCPT ); Fri, 17 Mar 2023 12:28:48 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8696F2BED6 for ; Fri, 17 Mar 2023 09:28:41 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id c2-20020a170903234200b001a0aecba4e1so2993865plh.16 for ; Fri, 17 Mar 2023 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679070521; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=fmYX3gNCXjYvZ39xUyb3MSpausxB4TkXxjOfXhXIaac=; b=FEzoG3T3UpGEl7aYVx+UfZd8Q3KJ0I6UW2fZGgYe062JnfCDHEVca37r8x3DfaOadN GATNiP4OkcJvfVqOZALejn1Bo2qePKM2N4ylXoY2I8VPPAgWl7OwjP3S3839OPx5DGmG wZqNc10p3WFdM3jBKvpAc3kAqPSxYuX4aI9O78YDl3OiYoVW3639zd1cZSAoRL+A/jJp 6xY7XZLumb6eN8LZirTi00PBXjR+c3s5HedeyZnZ4Fl99lgvMNuRhcmodtbkLKYyMuYo WpriWbl5MGxiVyRCjcdNDDbXqRwjryh750LMhxCem25vpyl+tl3KUGTQQF+X7ZRrFvip zizA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679070521; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fmYX3gNCXjYvZ39xUyb3MSpausxB4TkXxjOfXhXIaac=; b=kVJBKY2L6vdsoNkvLMsNA69pgl7V8ypKH4vS+bShl8TDu2J8XbPck+0RIFbv9Nq7kb qrYsYHbnXAt6kRP/9+i1RmpHHcMiKseooJNjueopjwFLWcCg5cYkqXmZuCel7RMdmEM0 6MYHeKu5mEE5EPW6IihcfrQzYCoYk+rfqS8L/0+gUma5wTVXWlet1ohF0njS1533c/Ah qaPjpNHqhd4Hvg3DRRuHpn4oFF2BVN64O2TeNXF5cQ2gSgxT9T2kKv3WntpcKk24Pccp dsRx4nzTmNcjcy1u53MTzMm7w7GJ3bnbjN0TBBVfAp7aCFCV0x7bXkD6ZdBOKAxmkAYK 8Z0g== X-Gm-Message-State: AO0yUKWFGwvZM1BwtgPHe1JJU/IpjDEH+7z/6Eq50hUMWmhnBVF7HWke kzI2PX+EcfffPpPWKWWS+70VQOwWHYtIIw== X-Google-Smtp-Source: AK7set9Sajyj/BaeqRmdDNsGz+OzZS4zUmsZcadO+TCx5F8PjYPEPWs9b2SFqXh8gGWtePtmNXYhVgBcAEAaAw== X-Received: from chooglen.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3a07]) (user=chooglen job=sendgmr) by 2002:a17:90b:1086:b0:23d:551c:c5fb with SMTP id gj6-20020a17090b108600b0023d551cc5fbmr2383653pjb.4.1679070520957; Fri, 17 Mar 2023 09:28:40 -0700 (PDT) Date: Fri, 17 Mar 2023 09:28:39 -0700 In-Reply-To: Mime-Version: 1.0 References: Message-ID: Subject: Re: [RFC PATCH 0/5] bypass config.c global state with configset From: Glen Choo To: "=?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason" , git@vger.kernel.org Cc: Jonathan Tan , Junio C Hamano , Jeff King , Emily Shaffer , Derrick Stolee , Calvin Wan , "=?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > That libification url > (https://github.com/git/git/compare/master...chooglen:git:config-lib-pars= ing) > doesn't work for me, and I didn't find a branch with that name in your > published repo. So maybe you've already done all this > post-libification work... Argh, sorry, I renamed the branch. https://github.com/git/git/compare/master...chooglen:git:config/read-with= out-globals > ...in any case. This RFC expands a bit on my comments on the v1 (at > [1] and upthread). It doesn't get all the way there, but with the > small change in 5/5 we've gotten rid of current_config_line(), the > 1-4/5 are trivial pre-refactorings to make that diff smaller > (e.g. moving the "struct key_value_info" around in config.h). Thanks. I haven't read through it yet, but it sounds promising :)