From: Glen Choo <chooglen@google.com>
To: Huang Zou <huang.zou@schrodinger.com>,
git@vger.kernel.org,
Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: Bug Report: fetch.recurseSubmodules doesn't affect git pull as otherwise stated in the git config docs
Date: Mon, 09 May 2022 16:32:31 -0700 [thread overview]
Message-ID: <kl6l5yme8epc.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <CAFnZ=JNE_Sa3TsKghBPj1d0cz3kc6o91Ogj-op8o6qK8t9hPgg@mail.gmail.com>
Huang Zou <huang.zou@schrodinger.com> writes:
> Thank you for filling out a Git bug report!
> Please answer the following questions to help us understand your issue.
>
> What did you do before the bug happened? (Steps to reproduce your issue)
> 1) Set the following configs:
> git config submodule.recurse true
> git config fetch.recurseSubmodules false
> 2) On a repo with submodules, run:
> git pull
>
> What did you expect to happen? (Expected behavior)
> git pull doesn't recursively fetch submodules
>
> What happened instead? (Actual behavior)
> Submodules are fetched recursively
>
> What's different between what you expected and what actually happened?
> Submodules are fetched recursively
>
> Anything else you want to add:
> git fetch works as intended. The documentation for fetch.recurseSubmodules
> states that "This option controls whether git fetch (and the underlying
> fetch in git pull)" so I would naturally expect git pull to behave the same
> as git fetch
>
>
>
> [System Info]
> git version:
> git version 2.36.0
> cpu: x86_64
> no commit associated with this build
> sizeof-long: 8
> sizeof-size_t: 8
> shell-path: /bin/sh
> feature: fsmonitor--daemon
> uname: Darwin 19.6.0 Darwin Kernel Version 19.6.0: Tue Aug 24 20:28:00 PDT
> 2021; root:xnu-6153.141.40~1/RELEASE_X86_64 x86_64
> compiler info: clang: 12.0.0 (clang-1200.0.32.29)
> libc info: no libc information available
> $SHELL (typically, interactive shell): /usr/local/bin/bash
>
>
> [Enabled Hooks]
> pre-commit
>
> Thanks,
> Huang
I've sent a fix at [1] :) I intended for the patch to be sent in reply
to this thread, but I clearly don't know how to use GitGitGadget
correctly. Whoops
[1] https://lore.kernel.org/git/pull.1262.git.git.1652138854255.gitgitgadget@gmail.com/
next prev parent reply other threads:[~2022-05-09 23:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 14:42 Bug Report: fetch.recurseSubmodules doesn't affect git pull as otherwise stated in the git config docs Huang Zou
2022-05-05 23:57 ` Philippe Blain
2022-05-06 21:50 ` Glen Choo
2022-05-06 22:24 ` Philippe Blain
2022-05-09 16:24 ` Huang Zou
2022-05-09 23:32 ` Glen Choo [this message]
2022-05-10 0:57 ` Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl6l5yme8epc.fsf@chooglen-macbookpro.roam.corp.google.com \
--to=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=huang.zou@schrodinger.com \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).