From: Glen Choo <chooglen@google.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 0/8] submodule: tests, cleanup to prepare for built-in
Date: Fri, 04 Nov 2022 10:10:29 -0700 [thread overview]
Message-ID: <kl6l35ayy7ay.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <cover-0.8-00000000000-20221102T074148Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> I have a topic on-list to remove git-submodule.sh and create a
> builtin/submodule.c, i.e. promoting "git submodule--helper" to the
> "real thing"[1].
>
> Glen gave me a bunch of good feedback on it, including (but not
> limited to) pointing out that we have outstanding dead code in
> [2][3].
>
> Once I started pulling at that thread things became a lot simpler for
> the re-roll of [1], e.g. the migration of git-submodule.sh's commands
> can squash in the "update" step, as it's no longer a special-case.
>
> But that also made the series larger, and it's conflicted with other
> outstanding patches. First René's strvec() cleanup in submodule.c, and
> currently with Glen's in-flight submodule topic.
>
> So here's "just the prep" part of that split-out. See also [4] and [5]
> for previous "prep" topics, we're getting closer...
>
> This only adds missing test coverage, and deletes dead code that we'd
> otherwise have to account for. Then 8/8 converts submodule--helper to
> use the OPT_SUBCOMMAND() API in 8/8.
Thanks for working at this so patiently :) I can't wait to see
git-submodule.sh gone.
The only issue I saw was the out-of-date test names in [1]. Otherwise, I
think this is ready to merge.
[1] https://lore.kernel.org/git/kl6lfsezofk9.fsf@chooglen-macbookpro.roam.corp.google.com
next prev parent reply other threads:[~2022-11-04 17:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 7:53 [PATCH 0/8] submodule: tests, cleanup to prepare for built-in Ævar Arnfjörð Bjarmason
2022-11-02 7:53 ` [PATCH 1/8] submodule--helper: move "config" to a test-tool Ævar Arnfjörð Bjarmason
2022-11-03 22:09 ` Glen Choo
2022-11-02 7:53 ` [PATCH 2/8] submodule tests: add tests for top-level flag output Ævar Arnfjörð Bjarmason
2022-11-03 22:30 ` Glen Choo
2022-11-02 7:54 ` [PATCH 3/8] submodule tests: test for a "foreach" blind-spot Ævar Arnfjörð Bjarmason
2022-11-02 7:54 ` [PATCH 4/8] submodule.c: refactor recursive block out of absorb function Ævar Arnfjörð Bjarmason
2022-11-02 7:54 ` [PATCH 5/8] submodule API & "absorbgitdirs": remove "----recursive" option Ævar Arnfjörð Bjarmason
2022-11-03 22:53 ` Glen Choo
2022-11-04 1:42 ` Ævar Arnfjörð Bjarmason
2022-11-04 13:07 ` FW: " Simpson, Phyllis
2022-11-04 17:08 ` Glen Choo
2022-11-02 7:54 ` [PATCH 6/8] submodule--helper: remove --prefix from "absorbgitdirs" Ævar Arnfjörð Bjarmason
2022-11-02 7:54 ` [PATCH 7/8] submodule--helper: drop "update --prefix <pfx>" for "-C <pfx> update" Ævar Arnfjörð Bjarmason
2022-11-02 7:54 ` [PATCH 8/8] submodule--helper: use OPT_SUBCOMMAND() API Ævar Arnfjörð Bjarmason
2022-11-03 23:31 ` Glen Choo
2022-11-04 1:22 ` Ævar Arnfjörð Bjarmason
2022-11-04 17:02 ` Glen Choo
2022-11-05 14:23 ` Ævar Arnfjörð Bjarmason
2022-11-07 17:16 ` Glen Choo
2022-11-04 17:10 ` Glen Choo [this message]
2022-11-04 19:07 ` [PATCH 0/8] submodule: tests, cleanup to prepare for built-in Taylor Blau
2022-11-08 14:10 ` [PATCH v2 0/9] " Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 1/9] submodule--helper: move "config" to a test-tool Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 2/9] submodule tests: add tests for top-level flag output Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 3/9] submodule--helper: fix a memory leak in "status" Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 4/9] submodule tests: test for a "foreach" blind-spot Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 5/9] submodule.c: refactor recursive block out of absorb function Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 6/9] submodule API & "absorbgitdirs": remove "----recursive" option Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 7/9] submodule--helper: remove --prefix from "absorbgitdirs" Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 8/9] submodule--helper: drop "update --prefix <pfx>" for "-C <pfx> update" Ævar Arnfjörð Bjarmason
2022-11-08 14:10 ` [PATCH v2 9/9] submodule--helper: use OPT_SUBCOMMAND() API Ævar Arnfjörð Bjarmason
2022-11-08 18:30 ` [PATCH v2 0/9] submodule: tests, cleanup to prepare for built-in Glen Choo
2022-11-08 18:34 ` Ævar Arnfjörð Bjarmason
2022-11-08 19:20 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl6l35ayy7ay.fsf@chooglen-macbookpro.roam.corp.google.com \
--to=chooglen@google.com \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).