git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Glen Choo <chooglen@google.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Elijah Newren" <newren@gmail.com>
Subject: ab/remove-implicit-use-of-the-repository (was Re: What's cooking in git.git (Mar 2023, #05; Wed, 22))
Date: Thu, 23 Mar 2023 10:12:24 -0700	[thread overview]
Message-ID: <kl6l355ve6iv.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <xmqqcz50bau4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> * ab/remove-implicit-use-of-the-repository (2023-03-17) 17 commits
>  - libs: use "struct repository *" argument, not "the_repository"
>  - post-cocci: adjust comments for recent repo_* migration
>  - cocci: apply the "revision.h" part of "the_repository.pending"
>  - cocci: apply the "rerere.h" part of "the_repository.pending"
>  - cocci: apply the "refs.h" part of "the_repository.pending"
>  - cocci: apply the "promisor-remote.h" part of "the_repository.pending"
>  - cocci: apply the "packfile.h" part of "the_repository.pending"
>  - cocci: apply the "pretty.h" part of "the_repository.pending"
>  - cocci: apply the "object-store.h" part of "the_repository.pending"
>  - cocci: apply the "diff.h" part of "the_repository.pending"
>  - cocci: apply the "commit.h" part of "the_repository.pending"
>  - cocci: apply the "commit-reach.h" part of "the_repository.pending"
>  - cocci: apply the "cache.h" part of "the_repository.pending"
>  - cocci: add missing "the_repository" macros to "pending"
>  - cocci: sort "the_repository" rules by header
>  - cocci: fix incorrect & verbose "the_repository" rules
>  - cocci: remove dead rule from "the_repository.pending.cocci"
>
>  Code clean-up around the use of the_repository.
>
>  Needs review.
>  source: <cover-00.17-00000000000-20230317T152724Z-avarab@gmail.com>

My opinion (which I think is shared by Elijah [1]) is that

a) the code changes look great, and are a very welcome cleanup
b) I don't know how to review cocci changes, so I'm not 100% confident
   in giving Reviewed-by

[1] https://lore.kernel.org/git/CABPp-BEdpTO=DRjLq_p+dgX68M0HUVB--3yQR4Sdp8rnFYeyfA@mail.gmail.com/

      reply	other threads:[~2023-03-23 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 23:55 What's cooking in git.git (Mar 2023, #05; Wed, 22) Junio C Hamano
2023-03-23 17:12 ` Glen Choo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kl6l355ve6iv.fsf@chooglen-macbookpro.roam.corp.google.com \
    --to=chooglen@google.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).