git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org,  karthik.188@gmail.com
Subject: Re: [RFC PATCH] diff: add option to report binary files in raw diffs
Date: Thu, 6 Nov 2025 15:52:02 -0600	[thread overview]
Message-ID: <id5zny6t4cr5eaow4ttvdmaksywazvgraq56m2x3wviw3rij7v@fhjfhva5favl> (raw)
In-Reply-To: <D80AE9D4-EE8D-4CAE-9212-2A592F45AB90@gmail.com>

On 25/11/05 07:14AM, Ben Knoble wrote:
> 
> > Le 4 nov. 2025 à 19:17, Justin Tobler <jltobler@gmail.com> a écrit :
> > Also, maybe this info could be on a newline following each raw diff
> > entry? Something like:
> > 
> >  :100644 100644 a1961526 e231acb1 M    foo
> >  binary=yy
> >  :100644 100644 31eedd5c 402a70d7 M    bar
> >  binary=nn
> > 
> 
> Whether combined or separate, self-documenting output is nice. Separate might be easier for line-oriented tools? Having to split on commas and loop looking for keywords seems like more work than just processing a line at a time. Idk.

Ya, I'm also a bit torn on whether a single line or multiple lines would
be best. I'm currently leaning back towards using just a single line as
I do think it is somewhat nice that each diff entry itself is on its own
line. Ultimately from the perspective of the parser, I don't think it
should matter too much whether its splits raw-extended output on a
command or newline.

In the next version, I'm thinking the output will look something like:

  $ git diff-tree --raw-extended=binary,crlf ...
  :100644 100644 a1961526 e231acb1 binary=yy,crlf=nn M  foo
  :100644 100644 31eedd5c 402a70d7 binary=nn,crlf=yy M  bar

Thanks,
-Justin


      reply	other threads:[~2025-11-06 21:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04  2:14 [RFC PATCH] diff: add option to report binary files in raw diffs Justin Tobler
2025-11-04  2:26 ` Junio C Hamano
2025-11-04  4:44   ` Junio C Hamano
2025-11-05  0:17     ` Justin Tobler
2025-11-05  8:04       ` Junio C Hamano
2025-11-06 21:42         ` Justin Tobler
2025-11-07  8:30           ` Torsten Bögershausen
2025-11-07 16:07             ` Junio C Hamano
2025-11-07 17:16             ` Justin Tobler
2025-11-07 17:26               ` Junio C Hamano
2025-11-05 12:14       ` Ben Knoble
2025-11-06 21:52         ` Justin Tobler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=id5zny6t4cr5eaow4ttvdmaksywazvgraq56m2x3wviw3rij7v@fhjfhva5favl \
    --to=jltobler@gmail.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).