From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2A7C31F44D for ; Wed, 27 Mar 2024 06:30:46 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=gouders.net header.i=@gouders.net header.a=rsa-sha256 header.s=gnet header.b=PhyX+yxo; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7966F1C23FD5 for ; Wed, 27 Mar 2024 06:30:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 115721F606; Wed, 27 Mar 2024 06:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gouders.net header.i=@gouders.net header.b="PhyX+yxo" Received: from mx10.gouders.net (mx10.gouders.net [202.61.206.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B611D8833 for ; Wed, 27 Mar 2024 06:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.61.206.94 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711521037; cv=none; b=ZK5LQhSGdSz+CcZkWQgR+g7Seg7UHL6utH5XEZVg3AFeXoFAhxjVpUW6e0VQBzJUe64SmfCHD/MAZCCzdmXsOP1IbKtBo6Nw8ja4k7dbnCNxDenHt1bdXp3zjDaOlQUcF38nUYhpKMdst/RQtTzs1/sqo9XLxvNp60VlUUbdPRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711521037; c=relaxed/simple; bh=vj62BGGVMExHhaTF0pqIKfli/lX5NUAIwkM1SeU+2cs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JBw9lhNDTAy6KlDYIJ3m7J+w+E4v5Ba4wi0ABImsVk0LzoM1b9Cfd2zxC/Mlt3GHwais5Ch+9IM2O9z+bAgbwdH6ggWHCYPsYHg0txvyRQxU3VQ9BMggBnATBupnfPhFJgM5uCXGwn7nlY14qOfgFVzM1BjY/UddbalrF90t/8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gouders.net; spf=pass smtp.mailfrom=gouders.net; dkim=pass (1024-bit key) header.d=gouders.net header.i=@gouders.net header.b=PhyX+yxo; arc=none smtp.client-ip=202.61.206.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gouders.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gouders.net Received: from localhost (ip-109-42-178-117.web.vodafone.de [109.42.178.117]) (authenticated bits=0) by mx10.gouders.net (8.17.1.9/8.17.1.9) with ESMTPSA id 42R6UKGL023017 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 27 Mar 2024 07:30:20 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gouders.net; s=gnet; t=1711521020; bh=vj62BGGVMExHhaTF0pqIKfli/lX5NUAIwkM1SeU+2cs=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=PhyX+yxo9L5LI1fVNq/XqQ/NnfYrJiSI++IC9kVb3FOjphqDvaIB8EJsSwVzT/toc C+dLYIwcqnmilSdoOlc328257n2gvglPgnPMcWRSVxx9O0lb0BNN6QvvSl5CQS3Y/l Qs74n1tfHA22o2FaxcB4mcxNIEZtIjLoLDBUD7gw= From: Dirk Gouders To: Junio C Hamano Cc: git@vger.kernel.org, Emily Shaffer , Kyle Lippincott Subject: Re: [PATCH v4 4/5] MyFirstObjectWalk: fix description for counting omitted objects In-Reply-To: (Junio C. Hamano's message of "Tue, 26 Mar 2024 13:24:47 -0700") References: <20240326130902.7111-5-dirk@gouders.net> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Wed, 27 Mar 2024 07:30:14 +0100 Message-ID: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Junio C Hamano writes: > Dirk Gouders writes: > >> Oh yes, you are right (as far as I can say): I would change this to >> something like: >> >> "Asking for this list of filtered objects may cause performance >> implications, however, because in this case, despite filtering objects, >> the possibly much larger set of all reachable objects must be processed >> in order to populate that list." > > Better, but the verb "cause" applied to "performance implications" > feels funny. It may "have" implications. Alternatively, it may > "cause" degradations. As implications can be both positive or > negative, it would be better to say "cause performancedegradations" > when you know if it is negative. Thank you for the clarification with "implications" I will fix it. Dirk >> (Later in the document, it is suggested to do timing with the two >> versions, which kind of follows up on the performance impact that is >> focused on, here. So, this doesn't remain an unresolved detail.) > > Great. > > Thanks.