git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Brandon Casey <casey@nrlssc.navy.mil>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 2/2] bash: add support for 'git stash pop --index' option
Date: Mon, 08 Jun 2009 11:42:15 -0500	[thread overview]
Message-ID: <g-qSjt6xP9cc8knb-2r7SsV783h1R4c8UDJrPsaIHkYcoFwgq_Dt_Q@cipher.nrlssc.navy.mil> (raw)
In-Reply-To: <3456b3a568969b2e0451cdc7a9beebfeb5763039.1244475542.git.szeder@ira.uka.de>

SZEDER Gábor wrote:
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---
>  contrib/completion/git-completion.bash |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index fa899eb..480d85e 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1887,7 +1887,10 @@ _git_stash ()
>  		apply,--*)
>  			__gitcomp "--index"
>  			;;
> -		show,--*|drop,--*|pop,--*|branch,--*)
> +		pop,--*)
> +			__gitcomp "--index"
> +			;;
> +		show,--*|drop,--*|branch,--*)
>  			COMPREPLY=()
>  			;;
>  		show,*|apply,*|drop,*|pop,*|branch,*)

pop takes the same options as apply, so you may want to have just one
case statement for the two options.  Like:

    apply,--*|pop,--*)

-brandon

  reply	other threads:[~2009-06-08 16:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 16:27 [PATCH 1/2] Documentation: mention 'git stash pop --index' option explicitly SZEDER Gábor
2009-06-08 16:28 ` [PATCH 2/2] bash: add support for 'git stash pop --index' option SZEDER Gábor
2009-06-08 16:42   ` Brandon Casey [this message]
2009-06-08 18:24 ` [PATCH 1/2] Documentation: mention 'git stash pop --index' option explicitly Brandon Casey
2009-06-08 21:23 ` Junio C Hamano
2009-06-08 21:42   ` SZEDER Gábor
2009-06-08 22:57     ` [PATCH v2 " SZEDER Gábor
2009-06-08 22:57       ` [PATCH v2 2/2] bash: add support for 'git stash pop --index' option SZEDER Gábor
2009-06-09  7:18         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=g-qSjt6xP9cc8knb-2r7SsV783h1R4c8UDJrPsaIHkYcoFwgq_Dt_Q@cipher.nrlssc.navy.mil \
    --to=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).