From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 865041F452 for ; Tue, 4 Apr 2023 13:31:27 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=f7xzAyco; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234118AbjDDNai (ORCPT ); Tue, 4 Apr 2023 09:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235026AbjDDNag (ORCPT ); Tue, 4 Apr 2023 09:30:36 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5988D358B for ; Tue, 4 Apr 2023 06:30:34 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id w13so12813777oik.2 for ; Tue, 04 Apr 2023 06:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680615033; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7Dp5pAZeAhl6Dlb996jYKEzkjfchLLr1AyPpbuRPgDw=; b=f7xzAycoYYxR0LRVNhOuPX4T0SzCghUO46OAL99PyGqC3aloobFL44REoIjZH/vPn4 dOxk1pJXXEi2uqD7zlRAi5UygBVyhjzpMhrj2rWDqQ7dxIg5SNg32+zaq2smNfCKCczZ cSmf2/DacyWm2TMLhViKLzqxqUZ/2+DUbswiwl/+ZEIk+Q0UH4lr9MuE+s41yY0Zko8i BhxNLwQb9I1k2xmCNjL3r5LfLQf+h1RxVAfBp8ALJXACvVOE7NqPIdjrh5j/3Fq7I6mi km+1u5cPgzwiAsNjFzyiWN3QbM1pNSnlIUSHAXyELW+86Pzm3KqhXMIzeAJ99dZUhhh9 kKjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615033; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Dp5pAZeAhl6Dlb996jYKEzkjfchLLr1AyPpbuRPgDw=; b=1t871AYnpUpzuvBT816DORRe4JrJUz2rr19fNDBFKFM0emg0Vx8udReDYA4CNqfUtV M/lXUnM4XFbv4qxCvUl8N/K0qr71xIp76GTdAqphWOIl3Z2npTwiH1KYM+oxfRmctg+F jX8sQiEKkiK2fOzmR3OpK6RuGtKyciisyekL0f5gU4i50Rkj5zdrXz0TbJfuqEIb/5OL O/h1Zmu1DwlYhxLy9eWOL4NFiQxnXOX1ZTqevorwS3QX8rgkjta4KyOEBBNrkKZHtm4P Pqku3PbRYgwybmMh+a6/K7o3ZlMDoWbcbfCYfaYgrxIEkkG+LdQGeMyK0RrI+2tw8L9j rScw== X-Gm-Message-State: AAQBX9fznIT5MlKaYNYXHKeq1K01q9daR+8yaUiY4YGT+TafnjwjYRpn dbITbv48p5bAxUjXvAgMlf10qEj+vrbVMZk/ X-Google-Smtp-Source: AKy350a0hEHsqZDS/c3m+XnHX1rBFG5mW0Zj8il3T68qGk/fCSLdTCsKQ8rn8Fb8NvOP7E4nhdCW8A== X-Received: by 2002:a05:6808:2813:b0:387:3a49:4733 with SMTP id et19-20020a056808281300b003873a494733mr1081544oib.59.1680615032130; Tue, 04 Apr 2023 06:30:32 -0700 (PDT) Received: from [10.136.10.190] ([194.199.146.45]) by smtp.gmail.com with ESMTPSA id r204-20020acadad5000000b00383eaf88e75sm5179469oig.39.2023.04.04.06.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:30:31 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 15:30:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2] branch: improve error log on branch not found by checking remotes refs Content-Language: en-US From: Clement Mabileau To: Junio C Hamano , ClementMabileau via GitGitGadget , mabileau.clement@gmail.com Cc: git@vger.kernel.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 3/23/23 16:51, Clement Mabileau wrote: > > Well maybe it got it from the original commit or from my GitHub > username, I can't know for sure. But sorry for that :/ , I'll make > sure it's fixed it for potential future contribution! > > Before fixing anything about the code maybe I should first address your > last point which is the interest of the patch in the first place (and I > should have started with that...). > > A few months earlier, for the first time, I had to delete a remote ref > (because of a fork I fetched but no longer wanted: maybe a designed > solution exists but I'm not aware of it). However, despite being used to > git I had a hard time figuring out how to do it, I tried different > things, one was `git branch -d origin/` (I recently discovered > that it was written in `git branch --help` but I didn't find it at the > time). Even googling it proved difficult (because of a poor keyword > choice I must confess), most results was dealing with deleting remote > branches, such as `git push remote :branch`. > In the end, I finally understood that I needed that `--remote` flag and > really regretted that there wasn't an hint message to head me towards > the solution when I was getting close to it. > > Now I hope you'll understand why I suggested this patch. Maybe I'm the > only one that ended up in this situation, in this case I'd understand > that you would no longer be interested in the patch! > However if you still are, I'll be happy to make the modification you > asked for. > > > Yeah probably, I'll fix it along with the other. > > Thanks for reviewing this! Well, it would be nice to have an answer in order to know if I should abandon this patch or not :) Thanks!