From: "Rubén Justo" <rjusto@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] completion: reflog with implicit "show"
Date: Thu, 29 Feb 2024 20:00:26 +0100 [thread overview]
Message-ID: <ff1c650b-5776-4881-ad0d-c39d311fa7e7@gmail.com> (raw)
In-Reply-To: <abe1c96d-48f7-4355-8688-e1fb05c67448@gmail.com>
On Wed, Feb 21, 2024 at 07:06:36PM +0100, Rubén Justo wrote:
> On Tue, Feb 20, 2024 at 17:46:20 -0800, Junio C Hamano wrote:
>
> > $ git reflog sho<TAB>
> > shot show
> >
> > That is what I would expect.
>
> Thank you for responding.
>
> Of course that's the logical expectation.
>
> However I'm not sure if it is sensible to offer completion for
> sub-commands mixed with branch names.
>
> Furthermore, I am also worried that such an approach implies making the
> user pay, probably unnecessarily many times, for __git_complete_refs in
> cases such as:
>
> $ git reflog <TAB><TAB> ;# the user may be just exploring the sub-commands
> $ git reflog s<TAB> ;# the user may be lazy and just want "show "
> $ git reflog show<TAB> ;# likewise, to complete the SP
> $ git reflog expir<TAB> ;# how often a expir... branch is expected here?
>
> The experienced user, if not most users, should be intuitive enough to
> circumvent the corner cases:
>
> $ git reflog <TAB><TAB>
> delete expire show
> ...
> $ git reflog s<TAB>
> ...
> $ git reflog show s<TAB>
> ...
> $ git reflog show shot
>
> This is why I choose to fallback to __git_complete_ref only when no
> other option is available.
>
> If you think, or anyone else, that these concerns don't make sense, I'm
> open to make it work as you described.
I am happy with the current iteration and I still think that mixing
branch names with options is a source of confusion.
However, this topic in the latest 'What's cooking' is marked with:
Expecting a reroll.
cf. <dd106d87-3363-426a-90a2-16e1f2d04661@gmail.com>
source: <98daf977-dbad-4d3b-a293-6a769895088f@gmail.com>
I am confused about what the expectation is.
Consider this message a ping as maybe the message I'm responding to has
been missed.
Thanks.
next prev parent reply other threads:[~2024-02-29 19:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 12:46 [PATCH 0/4] completion for git-reflog show Rubén Justo
2024-01-26 12:51 ` [PATCH 1/4] completion: introduce __gitcomp_subcommand Rubén Justo
2024-01-26 17:26 ` Junio C Hamano
2024-01-26 20:09 ` Rubén Justo
2024-01-26 20:34 ` Junio C Hamano
2024-01-26 12:51 ` [PATCH 2/4] completion: introduce __git_find_subcommand Rubén Justo
2024-01-26 17:30 ` Junio C Hamano
2024-01-27 13:20 ` Rubén Justo
2024-01-26 12:53 ` [PATCH 3/4] completion: reflog with implicit "show" Rubén Justo
2024-01-26 17:57 ` Junio C Hamano
2024-01-26 20:20 ` Rubén Justo
2024-02-21 1:46 ` Junio C Hamano
2024-02-21 18:06 ` Rubén Justo
2024-02-29 19:00 ` Rubén Justo [this message]
2024-02-29 19:22 ` Junio C Hamano
2024-01-26 12:53 ` [PATCH 4/4] completion: reflog show <log-options> Rubén Justo
2024-03-02 14:30 ` [PATCH v2 0/5] completion for git-reflog show Rubén Justo
2024-03-02 14:37 ` [PATCH v2 1/5] completion: reflog with implicit "show" Rubén Justo
2024-03-02 15:50 ` [PATCH v2 3/5] completion: reflog show <log-options> Rubén Justo
2024-03-02 15:51 ` [PATCH v2 2/5] completion: introduce __git_find_subcommand Rubén Justo
2024-03-02 15:52 ` [PATCH v2 4/5] completion: factor out __git_resolve_builtins Rubén Justo
2024-03-02 15:52 ` [PATCH v2 5/5] completion: reflog subcommands and options Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1c650b-5776-4881-ad0d-c39d311fa7e7@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).