From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Sangeeta <sangunb09@gmail.com>, Git List <git@vger.kernel.org>
Cc: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Lars Schneider <larsxschneider@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: Perf lib sanity tests fail on OSX
Date: Tue, 15 Dec 2020 21:18:02 -0500 [thread overview]
Message-ID: <fde32488-97e7-55f3-86d5-25f525492844@gmail.com> (raw)
In-Reply-To: <CAHjREB6QrR-FQzwOphgw1z1Rba=o7gNvEwomHc60aNH3EkQg5A@mail.gmail.com>
Hi Sangeeta,
Le 2020-12-15 à 14:08, Sangeeta a écrit :
> Hey everyone,
>
> The performance test, p0000-perf-lib-sanity.sh[1], is failing on my
> local OSX machine due to an error in the test_export of the foo
> variable. I think the test is failing because it is not able to export
> the `foo` variable using `test_export`.
> [1] https://github.com/git/git/blob/master/t/perf/p0000-perf-lib-sanity.sh#L26
It is not the export per se that fails (that would be very bad news
indeed), it is the shell magic in the 'test_run_perf_' function in
'perf-lib.sh' that uses a non-portable sed(1) invocation:
set | sed -n "s'"/'/'\\\\''/g"';s/^\\($test_export_\\)/export
'"'&'"'/p" >test_vars
As you might already know, since macOS has some BSD background/ancestry,
most POSIX utilities are closer to the OpenBSD/FreeBSD versions than to
their GNU/Linux counterparts.
I successfully ran p0000-perf-lib-sanity.sh on my Mac after installing
the GNU version of sed using Homebrew and making sure to follow the
indications in the 'Caveats' so that the sed from Homebrew is first in
PATH:
brew install gnu-sed
export PATH="/usr/local/opt/gnu-sed/libexec/gnubin:$PATH"
./p0000-perf-lib-sanity.sh
I do not know sed syntax enough to fix the invocation to make it
portable (nor do I know if it's possible).
I've CC-ed Johannes and Lars since they were involved in the thread you
mentioned.
> Thanks and Regards,
> Sangeeta
Cheers,
Philippe.
P.S. my usual email setup is broken at the moment so I'm sorry if this
email is formatted wrong.
P.P.S. and sorry for the re-send.
next prev parent reply other threads:[~2020-12-16 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 19:08 Perf lib sanity tests fail on OSX Sangeeta
2020-12-16 2:18 ` Philippe Blain [this message]
2020-12-16 7:44 ` Eric Sunshine
2020-12-22 5:23 ` Sangeeta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fde32488-97e7-55f3-86d5-25f525492844@gmail.com \
--to=levraiphilippeblain@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kaartic.sivaraam@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=sangunb09@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).