git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: "René Scharfe" <l.s.r@web.de>, "Git Mailing List" <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/3] csum-file: add hashwrite_be64()
Date: Thu, 12 Nov 2020 08:52:24 -0500	[thread overview]
Message-ID: <fcebe67f-f1d7-0069-01de-12844508cae1@gmail.com> (raw)
In-Reply-To: <16932ced-8bcd-89bd-b927-cae1bce0365a@web.de>

On 11/12/2020 7:20 AM, René Scharfe wrote:
> Add a helper function for hashing and writing 64-bit integers in network
> byte order.  It returns the number of written bytes.  This simplifies
> callers that keep track of the file offset, even though this number is a
> constant.
> 
> Suggested-by: Derrick Stolee <dstolee@microsoft.com>
> Original-patch-by: Taylor Blau <me@ttaylorr.com>

These patches are absolutely correct, and I'm glad to see them show up
in a very clear presentation. I had to go look to see why these were
not already present, with [1] being the last instance of these showing
up on-list. They did not get into the new version after a significant
refactor [2].

Thanks,
-Stolee

[1] https://lore.kernel.org/git/20200904202226.GA21837@nand.local/
[2] https://lore.kernel.org/git/cover.1599664389.git.me@ttaylorr.com/

  parent reply	other threads:[~2020-11-12 13:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 12:20 [PATCH 1/3] csum-file: add hashwrite_be64() René Scharfe
2020-11-12 12:22 ` [PATCH 2/3] midx: use hashwrite_be64() René Scharfe
2020-11-12 12:23 ` [PATCH 3/3] pack-write: " René Scharfe
2020-11-12 13:52 ` Derrick Stolee [this message]
2020-11-12 14:47   ` [PATCH 1/3] csum-file: add hashwrite_be64() Taylor Blau
2020-11-12 14:51 ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcebe67f-f1d7-0069-01de-12844508cae1@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).