From: Derrick Stolee <derrickstolee@github.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, vdye@github.com
Subject: Re: [PATCH v2 1/2] maintenance: add 'unregister --force'
Date: Mon, 26 Sep 2022 09:32:14 -0400 [thread overview]
Message-ID: <fc6739c3-2f7c-5dab-e4a2-8243deafde50@github.com> (raw)
In-Reply-To: <20220923130832.GA1761@szeder.dev>
On 9/23/2022 9:08 AM, SZEDER Gábor wrote:
> On Thu, Sep 22, 2022 at 01:37:16PM +0000, Derrick Stolee via GitGitGadget wrote:
>> static int maintenance_unregister(int argc, const char **argv, const char *prefix)
>> {
>> + int force = 0;
>> struct option options[] = {
>> + OPT_BOOL(0, "force", &force,
>> + N_("return success even if repository was not registered")),
>
> This could be shortened a bit by using OPT__FORCE() instead of
> OPT_BOOL(). OTOH, please make it a bit longer, and declare the option
> with the PARSE_OPT_NOCOMPLETE flag to hide it from completion:
Looks like I can do both like this:
OPT__FORCE(&force,
N_("return success even if repository was not registered"),
PARSE_OPT_NOCOMPLETE),
>> @@ -1538,11 +1545,23 @@ static int maintenance_unregister(int argc, const char **argv, const char *prefi
>> usage_with_options(builtin_maintenance_unregister_usage,
>> options);
>>
>> - config_unset.git_cmd = 1;
>> - strvec_pushl(&config_unset.args, "config", "--global", "--unset",
>> - "--fixed-value", "maintenance.repo", maintpath, NULL);
>> + for_each_string_list_item(item, list) {
>> + if (!strcmp(maintpath, item->string)) {
>> + found = 1;
>> + break;
>> + }
>> + }
>> +
>> + if (found) {
>> + config_unset.git_cmd = 1;
>> + strvec_pushl(&config_unset.args, "config", "--global", "--unset",
>> + "--fixed-value", key, maintpath, NULL);
>> +
>> + rc = run_command(&config_unset);
>
> It seems a bit heavy-handed to fork() an extra git process just to
> unset a config variable. Wouldn't a properly parametrized
> git_config_set_multivar_in_file_gently() call be sufficient? Though
> TBH I don't offhand know what those parameters should be, in
> particular whether there is a convenient way to find out the path of
> the global config file in order to pass it to this function.
>
> (Not an issue with this patch, as the context shows that this has been
> done with the extra process before; it just caught my eye.)
Thanks. I'll look into it.
-Stolee
next prev parent reply other threads:[~2022-09-26 15:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 1:02 [PATCH] maintenance: make unregister idempotent Derrick Stolee via GitGitGadget
2022-09-21 17:19 ` Junio C Hamano
2022-09-22 12:37 ` Derrick Stolee
2022-09-22 19:31 ` Junio C Hamano
2022-09-22 19:46 ` Derrick Stolee
2022-09-22 20:44 ` Junio C Hamano
2022-09-22 13:37 ` [PATCH v2 0/2] scalar: " Derrick Stolee via GitGitGadget
2022-09-22 13:37 ` [PATCH v2 1/2] maintenance: add 'unregister --force' Derrick Stolee via GitGitGadget
2022-09-23 13:08 ` SZEDER Gábor
2022-09-26 13:32 ` Derrick Stolee [this message]
2022-09-26 15:39 ` Ævar Arnfjörð Bjarmason
2022-09-26 17:25 ` Derrick Stolee
2022-09-26 19:17 ` Junio C Hamano
2022-09-22 13:37 ` [PATCH v2 2/2] scalar: make 'unregister' idempotent Derrick Stolee via GitGitGadget
2022-09-26 18:48 ` [PATCH v3 0/3] scalar: make unregister idempotent Derrick Stolee via GitGitGadget
2022-09-26 18:48 ` [PATCH v3 1/3] maintenance: add 'unregister --force' Derrick Stolee via GitGitGadget
2022-09-26 19:23 ` Junio C Hamano
2022-09-26 20:49 ` Derrick Stolee
2022-09-26 21:55 ` Junio C Hamano
2022-09-27 11:38 ` Derrick Stolee
2022-09-27 11:54 ` Derrick Stolee
2022-09-27 13:36 ` Ævar Arnfjörð Bjarmason
2022-09-27 13:55 ` Derrick Stolee
2022-09-26 18:48 ` [PATCH v3 2/3] scalar: make 'unregister' idempotent Derrick Stolee via GitGitGadget
2022-09-26 18:48 ` [PATCH v3 3/3] gc: replace config subprocesses with API calls Derrick Stolee via GitGitGadget
2022-09-26 19:27 ` Junio C Hamano
2022-09-27 13:56 ` [PATCH v4 0/4] scalar: make unregister idempotent Derrick Stolee via GitGitGadget
2022-09-27 13:56 ` [PATCH v4 1/4] maintenance: add 'unregister --force' Derrick Stolee via GitGitGadget
2022-09-27 13:56 ` [PATCH v4 2/4] scalar: make 'unregister' idempotent Derrick Stolee via GitGitGadget
2022-09-27 13:57 ` [PATCH v4 3/4] gc: replace config subprocesses with API calls Derrick Stolee via GitGitGadget
2022-09-27 13:57 ` [PATCH v4 4/4] string-list: document iterator behavior on NULL input Derrick Stolee via GitGitGadget
2022-09-27 16:39 ` Junio C Hamano
2022-09-27 16:31 ` [PATCH v4 0/4] scalar: make unregister idempotent Junio C Hamano
2022-09-27 16:54 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc6739c3-2f7c-5dab-e4a2-8243deafde50@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).