From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id C68811F8C4 for ; Tue, 29 Mar 2022 20:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241144AbiC2UDV (ORCPT ); Tue, 29 Mar 2022 16:03:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241125AbiC2UDJ (ORCPT ); Tue, 29 Mar 2022 16:03:09 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0505C1AE61B for ; Tue, 29 Mar 2022 13:01:26 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id w4so26330242wrg.12 for ; Tue, 29 Mar 2022 13:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=qLajjswiiX6/ldQlXRShnGxLPyX6FRm5cSbPF9HVv1I=; b=nZrARCFc93Ry+L4D2SAmXfWotji6EgyuNDY767Z8iplz2J2ON8O46tp+ilqphwrPSg 7wejuu41/sm0J6tGiDgDEY5D175Ty2sZYDi03zp2zW7csjNEQOJNf+zd4Y36oFwI5Yys 7Q9eGfHNaWSNmGfdvk9fp76oNKfZaeS0oSqEBe/721fy7ok0G75qqhFEKCunzJwBn2WL F0erT00R3zjiionMdhYl5ENI5uA/dD978Q5TzAETGB5pPaCqN+Hr0K500/1R0zyoPPs8 RT1u883XvyWbNfbqsIktrkQkZWstosiy5c2Ejy81isUXTWJcCsqtVL8ctb4CSmlsmoQj VQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=qLajjswiiX6/ldQlXRShnGxLPyX6FRm5cSbPF9HVv1I=; b=MughCP5mTiMJrem+Oyb/KYU8ECGWQrh1BK3FMy2ZuqhuLPGb8XD2SYxw6jQTI3A9E6 oetrHYGZo0GQu4ABmDDcQT2D2PB8hWrgQxqgqg0HZ6omPHkEaXY1761aqfOi3V3L25b3 sAGpQWEoWdAK78uTdkpQp98EPBjw7dvl5aMkINvoYws2FlxjXZpeHT73Hqsu5woLuuGM OSksH4lnJykuuab/V3LF+yMSuAek9atOwIJB95Q6ADyjyTxe99Mrwm7y6HPOW+573kZb 1mGKiq3PBbhPDa54lX3jgIQ07JQ2cTX5CH3juLAIrjMLFvrpDzL2TqgLIqJdlum8Ry9g K8TA== X-Gm-Message-State: AOAM530+GUsc2AL6BObih+wuVJLDR9p6x+2LvdYhsyG6AQxjJEXvnwwR V9ynwVmm1sEBsnu+srT/Q2b79i0qWk4= X-Google-Smtp-Source: ABdhPJzEMWadrY8WYrYRwR/2YQqCpyFKgo1aDSx7yB5SoMXVNuDwE+VvnzeTsDqtGfWXseTMA07SfQ== X-Received: by 2002:a5d:64c8:0:b0:204:ccc:4ba5 with SMTP id f8-20020a5d64c8000000b002040ccc4ba5mr33556335wri.409.1648584084340; Tue, 29 Mar 2022 13:01:24 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id k40-20020a05600c1ca800b0038c6c8b7fa8sm3064042wms.25.2022.03.29.13.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 13:01:23 -0700 (PDT) Message-Id: In-Reply-To: References: From: "Glen Choo via GitGitGadget" Date: Tue, 29 Mar 2022 20:01:19 +0000 Subject: [PATCH 4/4] branch: remove negative exit code Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: =?UTF-8?Q?=C3=86var_Arnfj=C3=B6r=C3=B0?= Bjarmason , Jonathan Tan , Glen Choo , Glen Choo Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Glen Choo Replace an instance of "exit(-1)" with "exit(1)". We don't use negative exit codes - they are misleading because Unix machines will coerce them to 8-bit unsigned values, losing the sign. Signed-off-by: Glen Choo --- branch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/branch.c b/branch.c index 4a8796489c7..eb231b950bb 100644 --- a/branch.c +++ b/branch.c @@ -263,7 +263,7 @@ static void setup_tracking(const char *new_ref, const char *orig_ref, string_list_append(tracking.srcs, orig_ref); if (install_branch_config_multiple_remotes(config_flags, new_ref, tracking.remote, tracking.srcs) < 0) - exit(-1); + exit(1); cleanup: string_list_clear(&tracking_srcs, 0); -- gitgitgadget