From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.5 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 90CA71F54E for ; Fri, 5 Aug 2022 14:22:00 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=github.com header.i=@github.com header.b="W2IRqYY0"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238133AbiHEOV6 (ORCPT ); Fri, 5 Aug 2022 10:21:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240924AbiHEOVy (ORCPT ); Fri, 5 Aug 2022 10:21:54 -0400 Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C34D1E0E1 for ; Fri, 5 Aug 2022 07:21:52 -0700 (PDT) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-10dc1b16c12so3087792fac.6 for ; Fri, 05 Aug 2022 07:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=qupqlFlf6movwzcpRZBfCiVWTM4oE0YTilpOsrN8Xyk=; b=W2IRqYY0aqArRi7YXSCfRpnjM2V0UazTklBKRzABMAknm2xmrIqO/x3qiRp7g4C93b jn4RpdrKaqnoODmWtXOGd9S/phPIQZtj4ynslN+gXibjB50ZZVMa4o8dD73tMYt5SYxr N6HTORR/VZH02reg2p/vJZrDe8KGAJbipoTftQ03zxDCT7Zs1NndYDwvirfSRoeXjATj HXcPL/8wpaOIlT50oHRaKGZIo3QqM1/MZQzqcGX/WhkBFCB5x1Oqrs1YwBhah0NTDh2W KSU/m8T+YTvndYbrFTUJpGUBMNDKPwP49iJqi+I63pCOAPdvY9LbZC+ChCs0RVOZwYf6 ATdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=qupqlFlf6movwzcpRZBfCiVWTM4oE0YTilpOsrN8Xyk=; b=JZIuCGgcGZ2VIt2PiqmdqFN6D6EYb9zQHiHysXVToCeKQtr1sjTuRIvs0SKVngvaN9 WMcJu9wZ9Weqe2jRB4Hk7831fjKsJ+kIaxhQTJojOnXSiF8hOONmeDO6xgs8t1BQmVFa VcYo0mYswggG5JF4U/0oaWhkc0Q/XCu5r7QRO9FNcSZJm/qRQ1e5+E+xU47Nf2qnYxQu pE6wVlxpjllAvfBGbZEIKNF5GMG/K+r6wMYnh7yohQvUNBm7hKEO0T7KxvOy9QEiXjrP j4jBGM89bWJrOrp6Q3XLpTVJPBE3wtbJacE73lccIWIYPbr5XVshzIfRWm67dzoVNkOk l2xQ== X-Gm-Message-State: ACgBeo1wMRaz/J3PT+kGVRazft4fflAqzvbPZgMmbMQtrNGja2fbeJE4 ROXLtJkxv6+JbjP2CMblE0sX X-Google-Smtp-Source: AA6agR7vWPEUNc8c03vtmUWj6r7FBhgmWObkQzklB0h/5pHONFzRcCk0aSAKrs4cLKAje5/gpybn+g== X-Received: by 2002:a05:6870:1699:b0:10e:a227:67e1 with SMTP id j25-20020a056870169900b0010ea22767e1mr3362861oae.129.1659709312112; Fri, 05 Aug 2022 07:21:52 -0700 (PDT) Received: from ?IPV6:2600:1700:e72:80a0:3928:8f07:23c6:89bf? ([2600:1700:e72:80a0:3928:8f07:23c6:89bf]) by smtp.gmail.com with ESMTPSA id x19-20020a056870a79300b0010e5a5dfcb4sm717245oao.0.2022.08.05.07.21.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 07:21:51 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 10:21:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 02/10] t4207: test coloring of grafted decorations Content-Language: en-US To: Junio C Hamano , Eric Sunshine Cc: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Derrick Stolee via GitGitGadget , Git List , Taylor Blau , Victoria Dye , Josh Steadmon References: <220803.86y1w5g7r0.gmgdl@evledraar.gmail.com> <220803.86les5fpfg.gmgdl@evledraar.gmail.com> From: Derrick Stolee In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 8/4/2022 1:23 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> it's hardly a cause for concern at this point (though, I still >> reflexively write the more portable notation as used by `OID_REGEX` >> and `_x05`, etc.). > > Yeah, use of predefined constants we have in our test framework > releaves us from having to worry about the issue, which is why > I too am in favor of using them. Thanks. Using $OID_REGEX (along with --no-abbrev) will work perfectly for this script. -Stolee