Re: Issue when using the fsmonitor-watchman hook?

[Kaartic Sivaraam <kaartic.sivaraam@gmail.com>]

Hi Stolee,

On 11/04/22 19:16, Derrick Stolee wrote:
>   
>> I recently installed v2.36.0-rc1 and started getting the warning about
>> the deprecation of core.useBuiltinFSMonitor configuration. It appeared
>> for each 'git' invocation which was a bit annoying. Fortunately, I had
>> some spare time so I went the route of actually applying the suggested
>> alternative rather than suppressing the warning.
> 
> So, the new alternative is to set core.fsmonitor=true, which continues
> to use the builtin FS Monitor. What advice did you see that was
> different?
> 

Ah ha. I should've guessed that. The actual advice I saw was the following:

   hint: core.useBuiltinFSMonitor will be deprecated soon; use 
core.fsmonitor instead
   hint: Disable this message with "git config 
advice.useCoreFSMonitorConfig false"

Rather than trying out configuring 'core.fsmonitor' to 'true', I went
and took a look at the documentation for it in git-config [doc] which
read as follows:

   If set, the value of this variable is used as a command which will
   identify all files that may have changed since the requested
   date/time.

That made me think the value could only be a command. So, it never
occurred to me that it could be a boolean. I just checked the local
doc that shows up when running `git config --help` in Windows and that
seems to clearly mention the behaviour that setting to `true` would
enable the built-in file system monitor. Looks like I made a mistake
and referred to the doc for v2.35.2 when trying out the v2.36.0-rc2 x-<

[doc]: 
https://git-scm.com/docs/git-config#Documentation/git-config.txt-corefsmonitor

> (Also, this thread will only apply to Git for Windows, since core Git
> did not include core.useBuiltinFSMonitor. Feel free to move this
> discussion to [1] if you'd rather talk there.)
> 
> [1] https://github.com/git-for-windows/git/discussions/3251
> 
> Hopefully using core.fsmonitor=true solves your issue.
>

Yeah. That works fine and suppresses the warning properly. Thanks!

> 
> If you really want to use the Watchman-based hook solution, then
> here's the rest of my response:
>
 > ...

I do wish to try out Watchman but not right now. For now, I suppose
I'm fine with whatever the builtin fsmonitor does. Anyways, thanks
for the details!


-- 
Sivaraam