list mirror (unofficial, one of many)
 help / color / Atom feed
From: Phillip Wood <>
To: Andrea Wyss <>,
Subject: Re: amend param not available to the pre-commit hook
Date: Sun, 2 Aug 2020 16:10:53 +0100
Message-ID: <> (raw)
In-Reply-To: <>

Hi Andrea

On 02/08/2020 14:22, Andrea Wyss wrote:
> Issue
> amend param not available to the pre-commit hook
> Problem
> Cannot write a pre-commit hook that stops amending a commit that is present in other branches.
> Steps to Reproduce (git version 2.21.1)
> 1. Code in the pre-commit hook:
>    echo "DEBUG 0='$0' 1='$1'"
> 2. run:
>    git commit --amend
> Current Result
>    DEBUG 0='.git/hooks/pre-commit' 1=''
> Expected Result
>    DEBUG 0='.git/hooks/pre-commit' 1='--amend'

I'm not sure why you expect this, the documentation for the pre-commit 
hook states 'this hook takes no parameters'

That does not mean that it would not be useful to have this information 
available to the pre-commit and possibly prepare-commit-msg hooks but it 
is not a bug. I'm not sure that adding a parameter to the hook is a good 
route as it may break existing hooks that do not expect any parameters, 
maybe we could pass it in the environment.

Best Wishes


> Please, let me know if you need other info.
> I'm looking forward for a fix or workaround.
> Thank you,
> Andrea Wyss

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-02 13:22 Andrea Wyss
2020-08-02 15:10 ` Phillip Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone