git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* Null pointer dereference in error pathway on git pull
@ 2021-01-26 20:31 Joshua Hudson
  2021-01-26 22:55 ` Jeff King
  0 siblings, 1 reply; 3+ messages in thread
From: Joshua Hudson @ 2021-01-26 20:31 UTC (permalink / raw)
  To: git

>git pull
remote: Azure Repos
remote: Found 452 objects to send. (157 ms)
Rfatal: the remote end hung up unexpectedly
fatal: early EOFs:  81% (367/452)
fatal: index-pack failed
warning: unable to unlink '(NULL)': Invalid argument


So it hits some kind of error (looks like network disconnect) and tries
to back out; passed a NULL pointer to unlink().

Apologies if this has been submitted before. A search didn't find it.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Null pointer dereference in error pathway on git pull
  2021-01-26 20:31 Null pointer dereference in error pathway on git pull Joshua Hudson
@ 2021-01-26 22:55 ` Jeff King
  2021-01-26 23:01   ` Joshua Hudson
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff King @ 2021-01-26 22:55 UTC (permalink / raw)
  To: Joshua Hudson; +Cc: git

On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:

> >git pull
> remote: Azure Repos
> remote: Found 452 objects to send. (157 ms)
> Rfatal: the remote end hung up unexpectedly
> fatal: early EOFs:  81% (367/452)
> fatal: index-pack failed
> warning: unable to unlink '(NULL)': Invalid argument
> 
> 
> So it hits some kind of error (looks like network disconnect) and tries
> to back out; passed a NULL pointer to unlink().
> 
> Apologies if this has been submitted before. A search didn't find it.

Which version of Git are you using? It sounds like the same bug fixed by
6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).
That's in v2.30.0.

-Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Null pointer dereference in error pathway on git pull
  2021-01-26 22:55 ` Jeff King
@ 2021-01-26 23:01   ` Joshua Hudson
  0 siblings, 0 replies; 3+ messages in thread
From: Joshua Hudson @ 2021-01-26 23:01 UTC (permalink / raw)
  To: Jeff King; +Cc: git

2.29.2; yeah it does look like it could be the same bug

On 1/26/2021 2:55 PM, Jeff King wrote:
> On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:
>
>>> git pull
>> remote: Azure Repos
>> remote: Found 452 objects to send. (157 ms)
>> Rfatal: the remote end hung up unexpectedly
>> fatal: early EOFs:  81% (367/452)
>> fatal: index-pack failed
>> warning: unable to unlink '(NULL)': Invalid argument
>>
>>
>> So it hits some kind of error (looks like network disconnect) and tries
>> to back out; passed a NULL pointer to unlink().
>>
>> Apologies if this has been submitted before. A search didn't find it.
> Which version of Git are you using? It sounds like the same bug fixed by
> 6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).
> That's in v2.30.0.
>
> -Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-27 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 20:31 Null pointer dereference in error pathway on git pull Joshua Hudson
2021-01-26 22:55 ` Jeff King
2021-01-26 23:01   ` Joshua Hudson

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).