From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>,
Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] annotate-tests: quote variable expansions containing path names
Date: Wed, 3 Feb 2021 18:23:03 +0100 [thread overview]
Message-ID: <f667e887-0ba0-af0a-91a9-d84d833422b0@kdbg.org> (raw)
In-Reply-To: <YBoy/F3tS3JtyhDX@coredump.intra.peff.net>
Am 03.02.21 um 06:22 schrieb Jeff King:
> On Sat, Jan 30, 2021 at 12:14:56PM -0500, Philippe Blain wrote:
>
>> Apart from that, maybe we could set up one of the CI jobs to
>> clone git.git into a path with spaces, to try to avoid these
>> kind of errors in the future ?
>
> We put a space in the temporary trash directory created by the test
> suite for exactly this purpose. So I was curious why it didn't detect
> this problem.
>
> It looks like it's because the issue is with $TEST_DIRECTORY, which is
> outside the trash directory.
Yes, correct. I was also suprised at first that this was not caught.
-- Hannes
prev parent reply other threads:[~2021-02-03 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 16:22 [PATCH] annotate-tests: quote variable expansions containing path names Johannes Sixt
2021-01-30 17:14 ` Philippe Blain
2021-02-03 5:22 ` Jeff King
2021-02-03 17:23 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f667e887-0ba0-af0a-91a9-d84d833422b0@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).