From: Bagas Sanjaya <firstname.lastname@example.org> To: Chinmoy Chakraborty <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [GSoC] Draft Proposal (Convert submodule to builtin) Date: Fri, 2 Apr 2021 12:32:50 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 01/04/21 18.40, Chinmoy Chakraborty wrote: > Greetings mentors, > > This is my draft proposal for the GSoC project, Convert submodule to builtin. > > It would be really helpful if you could review the draft and present your > > views on it :). > > > Regards, > > Chinmoy Chakraborty. > > > Link: https://github.com/chinmoy12c/GSoC/blob/master/GSoC_Git_proposal.pdf > Looking from your proposal, you seems like you're using Kali Linux as daily driver. Why do you do that? AFAIK Kali is for penetration testing purposes. I assumed that you know what you're doing if you use this distro as your general-purpose distro. And why not using Ubuntu/Mint/Debian/ Arch? Please see . : https://www.kali.org/docs/introduction/should-i-use-kali-linux/ But anyway, because we're at Git ML, let me review your proposal: > The following helper functions would be required to be implemented● A function to guess the directory name from the repository string. > ● A function for normalizing path, that is, removing multiple //; > leading ./; /./; /../; trailing / . > ● A function to check for tracked directories properly as pointed out > by Kaartic Sivaraam on the thread: > https://lore.kernel.org/git/ce151a1408291bb0991ce89459e36ee1 > email@example.com/. > ● A function to check if the path exists and is already a git repo, > else clone it. > ● A function to set the submodule config properly. > After implementation of all these helper methods, the main > `module_add()` function would be implemented using the helper > functions listed above as well as those helper functions which are > predefined. I know these helper functions will be required for porting `git-submodule.sh` and used by `module_add()`, but do you have any justification for these? Anyway, I copy-pasted the quotation above from your proposal in PDF format. but when I pasted it into text-only mail, it looks rather ugly. So next time when sending GSoC proposal for Git, I would like to see proposals in Markdown format (as well as PDF) for the reason above. Thanks. -- An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-04-02 5:33 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-01 11:40 Chinmoy Chakraborty 2021-04-02 5:32 ` Bagas Sanjaya [this message] 2021-04-02 6:31 ` Christian Couder 2021-04-02 7:05 ` Chinmoy Chakraborty 2021-04-03 14:14 ` Chinmoy Chakraborty 2021-04-05 14:44 ` Christian Couder 2021-04-06 19:53 ` Chinmoy Chakraborty 2021-04-08 9:11 ` Chinmoy Chakraborty 2021-04-10 12:03 ` Christian Couder 2021-04-02 7:04 ` Chinmoy Chakraborty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GSoC] Draft Proposal (Convert submodule to builtin)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).