From: Andrzej Hunt <andrzej@ahunt.org> To: Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org Cc: "Han-Wen Nienhuys" <hanwen@google.com>, "Jeff King" <peff@peff.net>, "Ramsay Jones" <ramsay@ramsayjones.plus.com>, "Jonathan Nieder" <jrnieder@gmail.com>, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, "Jonathan Tan" <jonathantanmy@google.com>, "Josh Steadmon" <steadmon@google.com>, "Emily Shaffer" <emilyshaffer@google.com>, "Patrick Steinhardt" <ps@pks.im>, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, "Felipe Contreras" <felipe.contreras@gmail.com>, "Derrick Stolee" <stolee@gmail.com>, "Han-Wen Nienhuys" <hanwenn@gmail.com> Subject: Re: [PATCH v7 23/28] Reftable support for git-core Date: Tue, 4 May 2021 19:24:20 +0200 [thread overview] Message-ID: <f5711aa9-e70f-8bb1-09d9-4f283b010d46@ahunt.org> (raw) In-Reply-To: <2fd7cb8c0983501e2af2f195aec81d7c17fb80e1.1618832277.git.gitgitgadget@gmail.com> On 19/04/2021 13:37, Han-Wen Nienhuys via GitGitGadget wrote: > From: Han-Wen Nienhuys <hanwen@google.com> [...snip...]> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c > new file mode 100644 > index 000000000000..55d053e5ca65 > --- /dev/null > +++ b/refs/reftable-backend.c [...snip...] > +static int write_transaction_table(struct reftable_writer *writer, void *arg) > +{ > + struct ref_transaction *transaction = (struct ref_transaction *)arg; > + struct git_reftable_ref_store *refs = > + (struct git_reftable_ref_store *)transaction->ref_store; > + struct reftable_stack *stack = > + stack_for(refs, transaction->updates[0]->refname); > + uint64_t ts = reftable_stack_next_update_index(stack); > + int err = 0; > + int i = 0; > + struct reftable_log_record *logs = > + calloc(transaction->nr, sizeof(*logs)); > + struct ref_update **sorted = > + malloc(transaction->nr * sizeof(struct ref_update *)); > + struct reftable_merged_table *mt = reftable_stack_merged_table(stack); > + struct reftable_table tab = {NULL}; > + struct reftable_ref_record ref = {NULL}; > + reftable_table_from_merged_table(&tab, mt); > + COPY_ARRAY(sorted, transaction->updates, transaction->nr); > + QSORT(sorted, transaction->nr, ref_update_cmp); > + reftable_writer_set_limits(writer, ts, ts); > + > + for (i = 0; i < transaction->nr; i++) { > + struct ref_update *u = sorted[i]; > + struct reftable_log_record *log = &logs[i]; > + struct object_id old_id; > + fill_reftable_log_record(log); > + log->update_index = ts; > + log->value_type = REFTABLE_LOG_UPDATE; > + log->refname = (char *)u->refname; > + log->update.new_hash = u->new_oid.hash; > + log->update.message = u->msg; > + > + err = reftable_table_read_ref(&tab, u->refname, &ref); > + if (err < 0) > + goto done; > + else if (err > 0) { > + old_id = null_oid; > + } else { > + oidread(&old_id, ref.value.val1); > + } This seems to assume that 'ref.value_type == REFTABLE_REF_VAL1' - but do we expect to have to handle the other types (REFTABLE_REF_VAL2/REFTABLE_REF_SYMREF)? When I run tests in seen against ASAN I see the following errors in t0031, which suggests we're running this code against REFTABLE_REF_SYMREF too - but I don't know if that means that this code should be able to handle the other ref types or if there's a bug higher up the stack. (AFAIUI REFTABLE_REF_DELETION is already handled because reftable_table_read_ref() already returns 1 for deletion, but the other cases seem valid?) ASAN error output: ==25352==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603000003353 at pc 0x000000499d17 bp 0x7fff0ea0a210 sp 0x7fff0ea099d8 READ of size 32 at 0x603000003353 thread T0 #0 0x499d16 in __asan_memcpy ../projects/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3 #1 0x97ed0a in oidread hash.h:292:2 #2 0x97ed0a in write_transaction_table refs/reftable-backend.c:548:4 #3 0xb5537a in reftable_addition_add reftable/stack.c:650:8 #4 0x97b024 in git_reftable_transaction_finish refs/reftable-backend.c:618:9 #5 0x95f9bf in ref_transaction_commit refs.c:2218:8 #6 0x9d3aa6 in update_head_with_reflog sequencer.c:1138:6 #7 0x52ffbf in cmd_commit builtin/commit.c:1814:6 #8 0x4ce8fe in run_builtin git.c:461:11 #9 0x4ccbc8 in handle_builtin git.c:718:3 #10 0x4cb0cc in run_argv git.c:785:4 #11 0x4cb0cc in cmd_main git.c:916:19 #12 0x6beded in main common-main.c:52:11 #13 0x7f415c762349 in __libc_start_main (/lib64/libc.so.6+0x24349) #14 0x420769 in _start ../sysdeps/x86_64/start.S:120 0x603000003353 is located 0 bytes to the right of 19-byte region [0x603000003340,0x603000003353) allocated by thread T0 here: #0 0x4868b4 in strdup ../projects/compiler-rt/lib/asan/asan_interceptors.cpp:452:3 #1 0xaa08e8 in xstrdup wrapper.c:29:14 #2 0xb4b280 in reftable_ref_record_copy_from reftable/record.c:229:23 #3 0xb46754 in merged_iter_next_entry reftable/merged.c:132:2 #4 0xb46754 in merged_iter_next reftable/merged.c:141:13 #5 0xb46754 in merged_iter_next_void reftable/merged.c:157:9 #6 0xb500ae in iterator_next reftable/generic.c:147:9 #7 0xb500ae in reftable_iterator_next_ref reftable/generic.c:134:9 #8 0xb500ae in reftable_table_read_ref reftable/generic.c:46:8 #9 0x97ec67 in write_transaction_table refs/reftable-backend.c:542:9 #10 0xb5537a in reftable_addition_add reftable/stack.c:650:8 #11 0x97b024 in git_reftable_transaction_finish refs/reftable-backend.c:618:9 #12 0x95f9bf in ref_transaction_commit refs.c:2218:8 #13 0x9d3aa6 in update_head_with_reflog sequencer.c:1138:6 #14 0x52ffbf in cmd_commit builtin/commit.c:1814:6 #15 0x4ce8fe in run_builtin git.c:461:11 #16 0x4ccbc8 in handle_builtin git.c:718:3 #17 0x4cb0cc in run_argv git.c:785:4 #18 0x4cb0cc in cmd_main git.c:916:19 #19 0x6beded in main common-main.c:52:11 #20 0x7f415c762349 in __libc_start_main (/lib64/libc.so.6+0x24349) SUMMARY: AddressSanitizer: heap-buffer-overflow ../projects/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3 in __asan_memcpy Produced using: make CC=clang-11 SANITIZE=address COPTS="-Og -g" GIT_TEST_OPTS=-v T=t0031-reftable.sh test > + > + /* XXX fold together with the old_id check below? */ > + > + log->update.old_hash = old_id.hash; > + if (u->flags & REF_LOG_ONLY) { > + continue; > + } > + > + if (u->flags & REF_HAVE_NEW) { > + struct reftable_ref_record ref = { NULL }; > + struct object_id peeled; > + > + int peel_error = peel_object(&u->new_oid, &peeled); > + ref.refname = (char *)u->refname; > + ref.update_index = ts; > + > + if (!peel_error) { > + ref.value_type = REFTABLE_REF_VAL2; > + ref.value.val2.target_value = peeled.hash; > + ref.value.val2.value = u->new_oid.hash; > + } else if (!is_null_oid(&u->new_oid)) { > + ref.value_type = REFTABLE_REF_VAL1; > + ref.value.val1 = u->new_oid.hash; > + } > + > + err = reftable_writer_add_ref(writer, &ref); > + if (err < 0) { > + goto done; > + } > + } > + } > + > + for (i = 0; i < transaction->nr; i++) { > + err = reftable_writer_add_log(writer, &logs[i]); > + clear_reftable_log_record(&logs[i]); > + if (err < 0) { > + goto done; > + } > + } > + > +done: > + assert(err != REFTABLE_API_ERROR); > + reftable_ref_record_release(&ref); > + free(logs); > + free(sorted); > + return err; > +} > + [...snip...]
next prev parent reply other threads:[~2021-05-04 17:24 UTC|newest] Thread overview: 251+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-16 19:10 [PATCH 00/13] reftable library Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 01/13] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 02/13] reftable: define the public API Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 03/13] vcxproj: adjust for the reftable changes Johannes Schindelin via GitGitGadget 2020-09-16 19:10 ` [PATCH 04/13] reftable: add a barebones unittest framework Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 05/13] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 06/13] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-09-20 1:00 ` Junio C Hamano 2020-09-21 13:13 ` Han-Wen Nienhuys 2020-09-24 7:21 ` Jeff King 2020-09-24 7:31 ` Jeff King 2020-09-24 17:22 ` Junio C Hamano 2020-09-16 19:10 ` [PATCH 07/13] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 08/13] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 09/13] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 10/13] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 11/13] reftable: file level tests Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 12/13] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-09-16 19:10 ` [PATCH 13/13] reftable: "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 00/13] reftable library Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 01/13] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-10-02 3:18 ` Jonathan Nieder 2020-10-01 16:10 ` [PATCH v2 02/13] reftable: define the public API Han-Wen Nienhuys via GitGitGadget 2020-10-02 3:58 ` Jonathan Nieder 2020-10-09 21:13 ` Emily Shaffer 2020-10-10 17:03 ` Han-Wen Nienhuys 2020-11-30 14:44 ` Han-Wen Nienhuys 2020-10-10 13:43 ` Han-Wen Nienhuys 2020-10-12 16:57 ` Jonathan Nieder 2020-11-30 14:55 ` Han-Wen Nienhuys 2020-10-08 1:41 ` Jonathan Tan 2020-10-10 16:57 ` Han-Wen Nienhuys 2020-10-01 16:10 ` [PATCH v2 03/13] vcxproj: adjust for the reftable changes Johannes Schindelin via GitGitGadget 2020-10-02 4:02 ` Jonathan Nieder 2020-10-02 11:43 ` Johannes Schindelin 2020-10-01 16:10 ` [PATCH v2 04/13] reftable: add a barebones unittest framework Han-Wen Nienhuys via GitGitGadget 2020-10-02 4:05 ` Jonathan Nieder 2020-10-08 1:45 ` Jonathan Tan 2020-10-08 22:31 ` Josh Steadmon 2020-10-01 16:10 ` [PATCH v2 05/13] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-10-02 4:12 ` Jonathan Nieder 2020-10-10 17:32 ` Han-Wen Nienhuys 2020-10-12 15:25 ` Jonathan Nieder 2020-10-12 17:05 ` Patrick Steinhardt 2020-10-12 17:45 ` Jonathan Nieder 2020-10-13 12:12 ` Johannes Schindelin 2020-10-13 15:47 ` Junio C Hamano 2020-10-15 11:46 ` Johannes Schindelin 2020-10-15 16:23 ` Junio C Hamano 2020-10-15 19:39 ` Johannes Schindelin 2020-10-16 9:15 ` Patrick Steinhardt 2020-10-02 14:01 ` Johannes Schindelin 2020-10-02 20:47 ` Junio C Hamano 2020-10-03 8:07 ` Johannes Schindelin 2020-10-08 1:48 ` Jonathan Tan 2020-10-10 17:28 ` Han-Wen Nienhuys 2020-10-11 10:52 ` Johannes Schindelin 2020-10-12 15:19 ` Jonathan Nieder 2020-10-12 18:44 ` Johannes Schindelin 2020-10-12 19:41 ` Jonathan Nieder 2020-10-12 20:27 ` Johannes Schindelin 2020-10-12 16:42 ` Junio C Hamano 2020-10-12 19:01 ` Johannes Schindelin 2020-10-23 9:13 ` Ævar Arnfjörð Bjarmason 2020-10-23 17:36 ` Junio C Hamano 2020-10-01 16:10 ` [PATCH v2 06/13] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-10-01 19:23 ` Junio C Hamano 2020-10-01 19:59 ` Ramsay Jones 2020-10-01 16:10 ` [PATCH v2 07/13] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 08/13] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:10 ` [PATCH v2 09/13] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:11 ` [PATCH v2 10/13] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:11 ` [PATCH v2 11/13] reftable: file level tests Han-Wen Nienhuys via GitGitGadget 2020-10-01 16:11 ` [PATCH v2 12/13] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-10-02 13:57 ` Johannes Schindelin 2020-10-02 17:08 ` Junio C Hamano 2020-10-04 18:39 ` Johannes Schindelin 2020-10-01 16:11 ` [PATCH v2 13/13] reftable: "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 00/16] reftable library Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 01/16] move sleep_millisec to git-compat-util.h Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 02/16] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:22 ` Ævar Arnfjörð Bjarmason 2020-11-26 19:42 ` [PATCH v3 03/16] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:23 ` Ævar Arnfjörð Bjarmason 2020-11-30 11:26 ` Han-Wen Nienhuys 2020-11-30 20:25 ` Han-Wen Nienhuys 2020-11-30 21:21 ` Felipe Contreras 2020-12-01 9:51 ` Han-Wen Nienhuys 2020-12-01 10:38 ` Felipe Contreras 2020-12-01 11:45 ` Ævar Arnfjörð Bjarmason 2020-12-01 13:34 ` Han-Wen Nienhuys 2020-12-01 23:13 ` Felipe Contreras 2020-12-01 23:03 ` Felipe Contreras 2020-11-26 19:42 ` [PATCH v3 04/16] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2020-11-27 9:13 ` Felipe Contreras 2020-11-27 10:25 ` Ævar Arnfjörð Bjarmason 2020-11-30 11:27 ` Han-Wen Nienhuys 2020-11-26 19:42 ` [PATCH v3 05/16] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:18 ` Felipe Contreras 2020-11-27 10:33 ` Ævar Arnfjörð Bjarmason 2020-11-26 19:42 ` [PATCH v3 06/16] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 07/16] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 08/16] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 09/16] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 10/16] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 11/16] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 12/16] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 13/16] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 14/16] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2020-11-27 10:59 ` Ævar Arnfjörð Bjarmason 2020-11-26 19:42 ` [PATCH v3 15/16] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2020-11-26 19:42 ` [PATCH v3 16/16] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 00/15] reftable library Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 01/15] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 02/15] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 03/15] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 04/15] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 05/15] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 06/15] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 07/15] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 08/15] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 09/15] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 10/15] reftable: read " Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 11/15] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 12/15] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 13/15] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-01-21 15:55 ` Ævar Arnfjörð Bjarmason 2021-01-21 16:14 ` Han-Wen Nienhuys 2021-01-21 16:21 ` Han-Wen Nienhuys 2021-01-26 13:44 ` Ævar Arnfjörð Bjarmason 2021-04-23 10:22 ` Han-Wen Nienhuys 2021-04-26 13:23 ` Ævar Arnfjörð Bjarmason 2021-04-26 16:17 ` Han-Wen Nienhuys 2021-04-28 16:32 ` Ævar Arnfjörð Bjarmason 2021-04-28 17:40 ` Han-Wen Nienhuys 2021-02-22 0:41 ` [PATCH] refs: introduce API function to write invalid null ref Stefan Beller 2021-02-22 1:20 ` Eric Sunshine 2021-02-22 3:09 ` Eric Sunshine 2021-02-22 18:38 ` Han-Wen Nienhuys 2020-12-09 14:00 ` [PATCH v4 14/15] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2020-12-09 14:00 ` [PATCH v4 15/15] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 00/15] reftable library Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 01/15] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 02/15] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 03/15] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 04/15] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 05/15] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 06/15] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 07/15] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 08/15] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 09/15] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 10/15] reftable: read " Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 11/15] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 12/15] reftable: rest of library Han-Wen Nienhuys via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 13/15] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-03-23 11:40 ` Derrick Stolee 2021-03-23 12:20 ` Ævar Arnfjörð Bjarmason 2021-03-23 20:14 ` Junio C Hamano 2021-03-23 20:12 ` Junio C Hamano 2021-03-12 20:19 ` [PATCH v5 14/15] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2021-03-12 20:19 ` [PATCH v5 15/15] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 00/20] reftable library Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 01/20] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 02/20] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2021-04-13 7:28 ` Ævar Arnfjörð Bjarmason 2021-04-13 10:50 ` Han-Wen Nienhuys 2021-04-13 13:41 ` Ævar Arnfjörð Bjarmason 2021-04-12 19:25 ` [PATCH v6 03/20] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 04/20] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2021-04-13 8:02 ` Ævar Arnfjörð Bjarmason 2021-04-13 10:58 ` Han-Wen Nienhuys 2021-04-13 12:56 ` Ævar Arnfjörð Bjarmason 2021-04-13 13:14 ` Ævar Arnfjörð Bjarmason 2021-04-15 15:00 ` Han-Wen Nienhuys 2021-04-12 19:25 ` [PATCH v6 05/20] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 06/20] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 07/20] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2021-04-12 21:40 ` Junio C Hamano 2021-04-13 8:19 ` Ævar Arnfjörð Bjarmason 2021-04-15 8:57 ` Han-Wen Nienhuys 2021-04-12 19:25 ` [PATCH v6 08/20] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 09/20] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 10/20] reftable: generic interface to tables Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 11/20] reftable: read reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 12/20] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 13/20] reftable: add a heap-based priority queue for reftable records Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 14/20] reftable: add merged table view Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 15/20] reftable: implement refname validation Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 16/20] reftable: implement stack, a mutable database of reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 17/20] reftable: add dump utility Han-Wen Nienhuys via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 18/20] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-04-13 7:18 ` Ævar Arnfjörð Bjarmason 2021-04-14 16:44 ` Han-Wen Nienhuys 2021-04-16 14:55 ` Ævar Arnfjörð Bjarmason 2021-04-16 18:47 ` Junio C Hamano 2021-04-12 19:25 ` [PATCH v6 19/20] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2021-04-12 19:25 ` [PATCH v6 20/20] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 00/28] reftable library Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 01/28] refs: ref_iterator_peel returns boolean, rather than peel_status Han-Wen Nienhuys via GitGitGadget 2021-04-20 18:47 ` Junio C Hamano 2021-04-21 10:15 ` Han-Wen Nienhuys 2021-04-21 23:28 ` Junio C Hamano 2021-04-19 11:37 ` [PATCH v7 02/28] refs: document reflog_expire_fn's flag argument Han-Wen Nienhuys via GitGitGadget 2021-04-20 19:34 ` Junio C Hamano 2021-04-27 15:21 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 03/28] refs/debug: trace into reflog expiry too Han-Wen Nienhuys via GitGitGadget 2021-04-20 19:41 ` Junio C Hamano 2021-04-22 17:27 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 04/28] hash.h: provide constants for the hash IDs Han-Wen Nienhuys via GitGitGadget 2021-04-20 19:49 ` Junio C Hamano 2021-04-21 1:04 ` brian m. carlson 2021-04-21 9:43 ` Han-Wen Nienhuys 2021-07-22 8:31 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 05/28] init-db: set the_repository->hash_algo early on Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 06/28] reftable: add LICENSE Han-Wen Nienhuys via GitGitGadget 2021-04-21 7:48 ` Ævar Arnfjörð Bjarmason 2021-04-21 9:15 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 07/28] reftable: add error related functionality Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 08/28] reftable: utility functions Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 09/28] reftable: add blocksource, an abstraction for random access reads Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 10/28] reftable: (de)serialization for the polymorphic record type Han-Wen Nienhuys via GitGitGadget 2021-05-04 17:23 ` Andrzej Hunt 2021-05-18 13:12 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 11/28] Provide zlib's uncompress2 from compat/zlib-compat.c Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 12/28] reftable: reading/writing blocks Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 13/28] reftable: a generic binary tree implementation Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 14/28] reftable: write reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 15/28] reftable: generic interface to tables Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 16/28] reftable: read reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 17/28] reftable: reftable file level tests Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 18/28] reftable: add a heap-based priority queue for reftable records Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 19/28] reftable: add merged table view Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 20/28] reftable: implement refname validation Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 21/28] reftable: implement stack, a mutable database of reftable files Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 22/28] reftable: add dump utility Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 23/28] Reftable support for git-core Han-Wen Nienhuys via GitGitGadget 2021-04-20 22:44 ` Junio C Hamano 2021-04-21 10:19 ` Han-Wen Nienhuys 2021-04-21 23:22 ` Junio C Hamano 2021-05-04 17:24 ` Andrzej Hunt [this message] 2021-05-18 13:18 ` Han-Wen Nienhuys 2021-05-18 13:30 ` Han-Wen Nienhuys 2021-04-19 11:37 ` [PATCH v7 24/28] git-prompt: prepare for reftable refs backend SZEDER Gábor via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 25/28] Add "test-tool dump-reftable" command Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 26/28] t1301: document what needs to be done for REFTABLE Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 27/28] t1401,t2011: parameterize HEAD.lock " Han-Wen Nienhuys via GitGitGadget 2021-04-19 11:37 ` [PATCH v7 28/28] t1404: annotate test cases with REFFILES Han-Wen Nienhuys via GitGitGadget 2021-04-21 7:45 ` [PATCH v7 00/28] reftable library Ævar Arnfjörð Bjarmason 2021-04-21 9:52 ` Han-Wen Nienhuys 2021-04-21 11:21 ` Ævar Arnfjörð Bjarmason 2021-04-26 17:59 ` Han-Wen Nienhuys
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f5711aa9-e70f-8bb1-09d9-4f283b010d46@ahunt.org \ --to=andrzej@ahunt.org \ --cc=Johannes.Schindelin@gmx.de \ --cc=avarab@gmail.com \ --cc=emilyshaffer@google.com \ --cc=felipe.contreras@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=hanwen@google.com \ --cc=hanwenn@gmail.com \ --cc=jonathantanmy@google.com \ --cc=jrnieder@gmail.com \ --cc=peff@peff.net \ --cc=ps@pks.im \ --cc=ramsay@ramsayjones.plus.com \ --cc=steadmon@google.com \ --cc=stolee@gmail.com \ --subject='Re: [PATCH v7 23/28] Reftable support for git-core' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).