From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
randall.s.becker@rogers.com, Git List <git@vger.kernel.org>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [Patch v1 3/3] t5562: replace /dev/zero with a pipe from generate_zero_bytes
Date: Tue, 12 Feb 2019 21:50:59 +0100 [thread overview]
Message-ID: <f3b506bb-52eb-3a1f-ba3d-0cf327271ab2@kdbg.org> (raw)
In-Reply-To: <xmqqd0nwex7w.fsf@gitster-ct.c.googlers.com>
Am 12.02.19 um 18:24 schrieb Junio C Hamano:
>>> diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh
>>> @@ -143,14 +143,14 @@ test_expect_success GZIP 'push gzipped empty' '
>>> test_expect_success 'CONTENT_LENGTH overflow ssite_t' '
>>> NOT_FIT_IN_SSIZE=$(ssize_b100dots) &&
>>> - env \
>>> + generate_zero_bytes infinity | env \
>>> CONTENT_TYPE=application/x-git-upload-pack-request \
>>> QUERY_STRING=/repo.git/git-upload-pack \
>>> PATH_TRANSLATED="$PWD"/.git/git-upload-pack \
>>> GIT_HTTP_EXPORT_ALL=TRUE \
>>> REQUEST_METHOD=POST \
>>> CONTENT_LENGTH="$NOT_FIT_IN_SSIZE" \
>>> - git http-backend </dev/zero >/dev/null 2>err &&
>>> + git http-backend >/dev/null 2>err &&
>
> Doesn't this "inifinity" mode have the same issue that was worked
> around by 6129c930 ("test-lib: limit the output of the yes utility",
> 2016-02-02) on Windows? If I read correctly, the process upstream
> of the pipe (in this case, perl producing a stream of infinite NULs)
> would not die when the downstream stops reading with SIGPIPE.
I think we do not have to worry, and the reason is that the
justification for 6129c930 is simply wrong.
As I did not find the patch series discussed here to pull and test, I
repeated the timing tests with t7610-mergetool.sh with and without
6129c930 reverted, and the difference is only in the noise. The reason
t7610 takes so long on Windows looks more like a consequence of the
10,000 processes that it spawns. It is a mystery to me how I came to the
conclusion that the change in 6129c930 would make a difference. :-(
-- Hannes
next prev parent reply other threads:[~2019-02-12 20:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 18:59 [Patch v1 0/3] 2.21.0-rc0 test fixes resulting from use of /dev/zero randall.s.becker
2019-02-09 18:59 ` [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function randall.s.becker
2019-02-10 2:05 ` Eric Sunshine
2019-02-10 19:19 ` Randall S. Becker
2019-02-12 0:37 ` Jeff King
2019-02-12 1:17 ` Eric Sunshine
2019-02-12 2:47 ` randall.s.becker
2019-02-09 18:59 ` [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes randall.s.becker
2019-02-10 2:07 ` Eric Sunshine
2019-02-12 17:18 ` Junio C Hamano
2019-02-13 17:25 ` Junio C Hamano
2019-02-13 18:18 ` Randall S. Becker
2019-02-13 21:00 ` Junio C Hamano
2019-02-13 21:03 ` Randall S. Becker
2019-02-09 18:59 ` [Patch v1 3/3] t5562: replace /dev/zero with a pipe from generate_zero_bytes randall.s.becker
2019-02-10 2:12 ` Eric Sunshine
2019-02-12 17:24 ` Junio C Hamano
2019-02-12 20:50 ` Johannes Sixt [this message]
2019-02-13 17:26 ` Junio C Hamano
2019-02-15 16:42 ` [PATCH] t5562: do not depend on /dev/zero Max Kirillov
2019-02-15 17:13 ` Randall S. Becker
2019-02-15 18:00 ` Junio C Hamano
2019-02-15 18:10 ` Randall S. Becker
2019-02-15 18:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b506bb-52eb-3a1f-ba3d-0cf327271ab2@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).