git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff Hostetler <git@jeffhostetler.com>
To: Carlo Arenas <carenas@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, jeffhost@microsoft.com
Subject: Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic
Date: Tue, 10 Aug 2021 09:52:09 -0400	[thread overview]
Message-ID: <f2d42d19-9378-5d10-cab4-1541027ad6aa@jeffhostetler.com> (raw)
In-Reply-To: <CAPUEspioazo0js5pZj7TzR2=j-+Aeh+XHr8Nbsszs6cq+WJqmw@mail.gmail.com>



On 8/10/21 1:49 AM, Carlo Arenas wrote:
> On Mon, Aug 9, 2021 at 9:49 AM Junio C Hamano <gitster@pobox.com> wrote:
>> Jeff, I understand that this is planned to be rerolled post release,
>> so I'll not touch these fixups and let you worry about them ;-)
> 
> Jeff,
> 
> As I mentioned in the cover letter[1] there is an extra patch[2] not
> in the series and that also applies to maint, but is not critical and
> might be better if included with your reroll IMHO, thanks.
> 
> Carlo
> 
> [1] https://lore.kernel.org/git/20210809063004.73736-1-carenas@gmail.com/
> [2] https://lore.kernel.org/git/20210809072551.94391-1-carenas@gmail.com/
> 

You're talking about the commit with "%lf" vs "%f".

I saw that, but I was unsure what it had to do with my FSMonitor
series.  It seemed like it could just be a standalone patch by itself.

(I'm not opposed to including it in mine, but it'd be easier and
quicker to just treat it in isolation, IMHO.)

Thoughts??

Jeff

  reply	other threads:[~2021-08-10 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  6:30 [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic Carlo Marcelo Arenas Belón
2021-08-09  6:30 ` [PATCH 1/2] fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon Carlo Marcelo Arenas Belón
2021-08-09  6:30 ` [PATCH 2/2] fixup! fsmonitor--daemon: implement handle_client callback Carlo Marcelo Arenas Belón
2021-08-09  7:25 ` [PATCH] test-path-utils: use a C89 compatible format for double printf Carlo Marcelo Arenas Belón
2021-08-09 14:34 ` [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic Jeff Hostetler
2021-08-09 16:49   ` Junio C Hamano
2021-08-10  5:49     ` Carlo Arenas
2021-08-10 13:52       ` Jeff Hostetler [this message]
2021-08-10 13:41     ` Jeff Hostetler
2021-08-27  5:37       ` Junio C Hamano
2021-08-27  6:04         ` Carlo Arenas
2021-08-27 17:11           ` Junio C Hamano
2021-08-28  9:45             ` Carlo Arenas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2d42d19-9378-5d10-cab4-1541027ad6aa@jeffhostetler.com \
    --to=git@jeffhostetler.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).