From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] builtin/index-pack.c: fix some sparse warnings
Date: Thu, 27 Aug 2020 01:40:07 +0100 [thread overview]
Message-ID: <f2c8b658-f9d8-43bd-7121-9e0f04adeb4b@ramsayjones.plus.com> (raw)
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Jonathan,
If you need to re-roll your 'jt/threaded-index-pack' branch, could you
please squash this into the relevant patch (commit 4a03e3d995 (index-pack:
make quantum of work smaller, 24-08-2020)).
Thanks!
ATB,
Ramsay Jones
builtin/index-pack.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index 3a20017102..8acd078aa0 100644
--- a/builtin/index-pack.c
+++ b/builtin/index-pack.c
@@ -65,7 +65,7 @@ struct base_data {
*
* Guarded by work_mutex.
*/
-LIST_HEAD(work_head);
+static LIST_HEAD(work_head);
/*
* Stack of struct base_data that have children, all of whom have been
@@ -75,7 +75,7 @@ LIST_HEAD(work_head);
*
* Guarded by work_mutex.
*/
-LIST_HEAD(done_head);
+static LIST_HEAD(done_head);
/*
* All threads share one delta base cache.
@@ -83,8 +83,8 @@ LIST_HEAD(done_head);
* base_cache_used is guarded by work_mutex, and base_cache_limit is read-only
* in a thread.
*/
-size_t base_cache_used;
-size_t base_cache_limit;
+static size_t base_cache_used;
+static size_t base_cache_limit;
struct thread_local {
pthread_t thread;
--
2.28.0
reply other threads:[~2020-08-27 0:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2c8b658-f9d8-43bd-7121-9e0f04adeb4b@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).