From: Derrick Stolee <stolee@gmail.com> To: Nathaniel Filardo <nwf20@cl.cam.ac.uk>, git@vger.kernel.org Cc: Derrick Stolee <dstolee@microsoft.com> Subject: Re: [PATCH 3/4] repack: add --sparse and pass to pack-objects Date: Tue, 12 Mar 2019 09:47:18 -0400 Message-ID: <f26c68df-8895-2a2d-0175-5fa3581ab45a@gmail.com> (raw) In-Reply-To: <20190312131858.26115-4-nwf20@cl.cam.ac.uk> On 3/12/2019 9:18 AM, Nathaniel Filardo wrote: > The sparse connectivity algorithm saves a whole lot of time when there > are UNINTERESTING trees around. Interesting! Do you have some performance numbers to include with this statement? > @@ -48,6 +49,10 @@ static int repack_config(const char *var, const char *value, void *cb) > use_delta_islands = git_config_bool(var, value); > return 0; > } > + if (!strcmp(var, "pack.usesparse")) { > + sparse = git_config_bool(var, value); > + return 0; > + } This part is not handled inside of `pack-objects`. Since you are not sending '--no-sparse' when the variable 'sparse' is zero, the config setting will automatically be picked up by the pack-objects builtin. Now, a question of whether you _should_ allow the '--no-sparse' option in the 'repack' command, and send it along to the inner command (when it is present) is another question. > @@ -366,6 +374,8 @@ int cmd_repack(int argc, const char **argv, const char *prefix) > argv_array_push(&cmd.args, "--all"); > argv_array_push(&cmd.args, "--reflog"); > argv_array_push(&cmd.args, "--indexed-objects"); > + if (sparse) > + argv_array_push(&cmd.args, "--sparse"); > if (repository_format_partial_clone) > argv_array_push(&cmd.args, "--exclude-promisor-objects"); > if (write_bitmaps) > How about a test with this new option? You can probably just add to t5322-pack-objects-sparse.sh. Thanks, -Stolee
next prev parent reply other threads:[~2019-03-12 13:47 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-12 13:18 [PATCH 0/4] Speed up repacking when lots of pack-kept objects Nathaniel Filardo 2019-03-12 13:18 ` [PATCH 1/4] count-objects: report statistics about kept packs Nathaniel Filardo 2019-03-12 13:18 ` [PATCH 2/4] revision walk: optionally use sparse reachability Nathaniel Filardo 2019-03-12 13:59 ` Derrick Stolee 2019-03-12 13:18 ` [PATCH 3/4] repack: add --sparse and pass to pack-objects Nathaniel Filardo 2019-03-12 13:47 ` Derrick Stolee [this message] 2019-03-12 14:03 ` Dr N.W. Filardo 2019-03-12 13:18 ` [PATCH 4/4] repack: optionally assume transitive kept packs Nathaniel Filardo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f26c68df-8895-2a2d-0175-5fa3581ab45a@gmail.com \ --to=stolee@gmail.com \ --cc=dstolee@microsoft.com \ --cc=git@vger.kernel.org \ --cc=nwf20@cl.cam.ac.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git