git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Glen Choo <chooglen@google.com>,
	Carlo Arenas <carenas@gmail.com>
Subject: Re: [PATCH] Documentation: specify base point when generating MyFirstContribution patchset
Date: Fri, 15 Oct 2021 13:51:39 +0700	[thread overview]
Message-ID: <f25fae40-0313-287b-5482-1c64cbe8cb64@gmail.com> (raw)
In-Reply-To: <xmqq1r4ofz0o.fsf@gitster.g>

On 14/10/21 03.30, Junio C Hamano wrote:
> 	Side note. We want a new feature to be built on 'master' (or
> 	the last feature release, if nothing in flight conflicts
> 	with it)), and a bugfix to be built on one of the older
> 	release point (to be applicable to the maintenance tracks).
> 	But the section we are discussing, i.e. how to run
> 	format-patch, is not the place to do so, as it is too
> 	late---it must be decided before the contributor starts
> 	working on the series.  As the example of this document is
> 	about adding a new "feature", we should have a sentence to
> 	explain, in the "Set up your workspace" section, why we
> 	chose 'master' as the base point (and the existing text
> 	already says why).

It has been described before:

> Let's start by making a development branch to work on our changes. Per
> `Documentation/SubmittingPatches`, since a brand new command is a new feature,
> it's fine to base your work on `master`. However, in the future for bugfixes,
> etc., you should check that document and base it on the appropriate branch.

Leave it as is?

-- 
An old man doll... just what I always wanted! - Clara

  reply	other threads:[~2021-10-15  6:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 12:22 [PATCH] Documentation: specify base point when generating MyFirstContribution patchset Bagas Sanjaya
2021-10-13 20:30 ` Junio C Hamano
2021-10-15  6:51   ` Bagas Sanjaya [this message]
2021-10-15 16:26     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f25fae40-0313-287b-5482-1c64cbe8cb64@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=carenas@gmail.com \
    --cc=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).