From: "René Scharfe" <l.s.r@web.de>
To: Han-Wen Nienhuys <hanwen@google.com>, Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>,
Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>
Subject: Re: [PATCH RESEND] branch: allow deleting dangling branches with --force
Date: Thu, 26 Aug 2021 20:18:53 +0200 [thread overview]
Message-ID: <f2511e9a-cc0f-20d0-d196-5dacdd637b7d@web.de> (raw)
In-Reply-To: <CAFQ2z_Mwj0+uWO-Ly8MTHmidjf=1P-9K1n2f0DSNzN=Or2t=bw@mail.gmail.com>
Am 26.08.21 um 09:26 schrieb Han-Wen Nienhuys:
> On Wed, Aug 25, 2021 at 11:37 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>>> +test_expect_success 'branch --delete --force removes dangling branch' '
>>> + test_when_finished "rm -f .git/refs/heads/dangling" &&
>>> + echo $ZERO_OID >.git/refs/heads/dangling &&
>>> + git branch --delete --force dangling &&
>>> + test_path_is_missing .git/refs/heads/dangling
>>> +'
>>
>> This goes against the spirit of the series merged at c9780bb2 (Merge
>> branch 'hn/prep-tests-for-reftable', 2021-07-13).
I assume the file backend won't go away anytime soon. So I guess the
idea is that the test suite is supposed to be run with the new backend
as default and exercise it?
>> Can we creat the dangling ref and test the lack of "dangling" ref in
>> the end in a less transparent way?
>
> agreed. Try the ref-store test-helper's update-ref command?
It requires the new hash to refer to an existing object, so we can't
use it in this test.
René
next prev parent reply other threads:[~2021-08-26 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 20:43 [PATCH RESEND] branch: allow deleting dangling branches with --force René Scharfe
2021-08-25 21:37 ` Junio C Hamano
2021-08-25 23:28 ` Ævar Arnfjörð Bjarmason
2021-08-26 18:19 ` René Scharfe
2021-08-26 7:26 ` Han-Wen Nienhuys
2021-08-26 16:54 ` Junio C Hamano
2021-08-26 17:38 ` Junio C Hamano
2021-08-27 7:24 ` Antw: [EXT] Re: [PATCH RESEND] branch: allow deleting dangling branches with ‑‑force Ulrich Windl
2021-08-27 7:53 ` Ævar Arnfjörð Bjarmason
2021-08-26 18:18 ` René Scharfe [this message]
2021-08-25 23:30 ` [PATCH RESEND] branch: allow deleting dangling branches with --force Ævar Arnfjörð Bjarmason
2021-08-26 18:19 ` René Scharfe
2021-08-26 18:19 ` [PATCH v2] " René Scharfe
2021-08-26 19:05 ` Junio C Hamano
2021-08-26 21:01 ` René Scharfe
2021-08-26 19:12 ` Ævar Arnfjörð Bjarmason
2021-08-27 18:35 ` [PATCH v3] " René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2511e9a-cc0f-20d0-d196-5dacdd637b7d@web.de \
--to=l.s.r@web.de \
--cc=Ulrich.Windl@rz.uni-regensburg.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).