From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 9D7071F8C8 for ; Thu, 23 Sep 2021 14:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241519AbhIWONG (ORCPT ); Thu, 23 Sep 2021 10:13:06 -0400 Received: from siwi.pair.com ([209.68.5.199]:40602 "EHLO siwi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241304AbhIWONG (ORCPT ); Thu, 23 Sep 2021 10:13:06 -0400 Received: from siwi.pair.com (localhost [127.0.0.1]) by siwi.pair.com (Postfix) with ESMTP id 7F2A23F4095; Thu, 23 Sep 2021 10:11:34 -0400 (EDT) Received: from WIN10-A.eucom.mil (162-238-212-202.lightspeed.rlghnc.sbcglobal.net [162.238.212.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id 520343F4090; Thu, 23 Sep 2021 10:11:34 -0400 (EDT) Subject: Re: [PATCH 1/5] fsmonitor: enhance existing comments To: Junio C Hamano , Bagas Sanjaya Cc: Jeff Hostetler via GitGitGadget , git@vger.kernel.org, Jeff Hostetler References: <6be687ba39d49f56a0729d3197ecbf3a64041357.1631822063.git.gitgitgadget@gmail.com> <2b7f0885-bb76-d695-941d-3160a8d62ccc@gmail.com> From: Jeff Hostetler Message-ID: Date: Thu, 23 Sep 2021 10:11:33 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 9/17/21 2:44 AM, Junio C Hamano wrote: > Bagas Sanjaya writes: > >> On 17/09/21 02.54, Jeff Hostetler via GitGitGadget wrote: >>> - /* If we're going to check every file, ensure we save the results */ >>> + /* >>> + * If we're going to check every file, ensure we save >>> + * the results. >>> + */ >> >> Why did you split the comment above? > > I would guess that the reason why it is done is because the original > line is overly long it (extends to 84 columns, if I am counting > correctly). > Yes, I just wrapped it because it was too long and the commit was focused on improving other nearby comments (and no code), so it seemed like a good opportunity to cleanup this one too. Jeff