git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: parth gala <parthpgala@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 0/5] object.c: localize global the_repository variable into r
Date: Thu, 13 Feb 2020 10:44:49 +0530
Message-ID: <f1e4da02-9411-8a93-ca62-6d7ae7bf4ae8@gmail.com> (raw)
In-Reply-To: <20200212201810.GB4364@syl.local>


On 13/02/20 1:48 am, Taylor Blau wrote:
> Hi Parth,
>
> On Wed, Feb 12, 2020 at 07:19:06PM +0000, Parth Gala via GitGitGadget wrote:
>> I have created this commit in response to
>> https://github.com/gitgitgadget/git/issues/379#issue-503866117.
> Fantastic! Thank you for working on this.
>
>> All the functions in object.c which relied on 'the_repository' have
>> been modified.  The functions calling these functions in object.c
>> consisted calls to other functions using 'the_repository' as well, and
>> although I intended to use 'r' at all those instances, I thought it
>> would make more sense when we would deal with their callee functions
>> in another similar patch. What do you think ?
> That makes sense, and follows the conventions that other similar
> refactorings have done in the past.
>
> Any reason why you decided to start with 'object.c'? Not that any such
> reason is necessary, I'm just curious about how you came to this
> decision.

I am new to the git community and while searching for issues to solve I
found the issue linked above. I figured solving it would give me a good
experience navigating between functions and exploring the huge repository.

Initially I grepped to find all functions using `the_repository` but
randomly chose object.c since the refactoring had to start somewhere.
Special thanks to Johannes Schindelin for this.

>> Signed-off-by: Parth Gala parthpgala@gmail.com [parthpgala@gmail.com]
> Even though you *do* need a 'Signed-off-by' in each of your patches,
> adding it in the cover letter is not necessary.

I probably did not check the preview I sent to myself carefully for
this. Will make note of it.

>> Parth Gala (5):
>>    object.c: get_max_object_index and get_indexed_object accept 'r'
>>      parameter
>>    object.c: lookup_unknown_object() accept 'r' as parameter
>>    object.c: parse_object_or_die() accept 'r' as parameter
>>    object.c: clear_object_flags() accept 'r' as parameter
>>    object.c: clear_commit_marks_all() accept 'r' as parameter
>>
>>   builtin/checkout.c               |  3 ++-
>>   builtin/fsck.c                   |  8 +++++---
>>   builtin/grep.c                   |  6 ++++--
>>   builtin/index-pack.c             |  5 +++--
>>   builtin/log.c                    |  3 ++-
>>   builtin/name-rev.c               |  5 +++--
>>   builtin/pack-objects.c           |  3 ++-
>>   builtin/prune.c                  |  3 ++-
>>   bundle.c                         |  8 +++++---
>>   http-push.c                      |  3 ++-
>>   object.c                         | 32 ++++++++++++++++----------------
>>   object.h                         | 12 ++++++------
>>   pack-bitmap.c                    |  5 +++--
>>   reachable.c                      |  6 ++++--
>>   refs.c                           |  3 ++-
>>   revision.c                       |  3 ++-
>>   shallow.c                        | 13 ++++++++-----
>>   t/helper/test-example-decorate.c |  7 ++++---
>>   upload-pack.c                    | 19 ++++++++++++-------
>>   walker.c                         |  3 ++-
>>   20 files changed, 89 insertions(+), 61 deletions(-)
>>
>>
>> base-commit: 0ad714499976290d9a0229230cbe4efae930b8dc
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-545%2FParthGala2k%2Flocalize-the_repository-variable-v1
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-545/ParthGala2k/localize-the_repository-variable-v1
>> Pull-Request: https://github.com/gitgitgadget/git/pull/545
>> --
>> gitgitgadget
> Thanks,
> Taylor

      reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 19:19 Parth Gala via GitGitGadget
2020-02-12 19:19 ` [PATCH 1/5] object.c: get_max_object_index and get_indexed_object accept 'r' parameter Parth Gala via GitGitGadget
2020-02-12 20:22   ` Taylor Blau
2020-02-12 21:13     ` Eric Sunshine
2020-02-13  5:23     ` parth gala
2020-02-12 19:19 ` [PATCH 2/5] object.c: lookup_unknown_object() accept 'r' as parameter Parth Gala via GitGitGadget
2020-02-12 20:25   ` Taylor Blau
2020-02-12 21:11     ` Junio C Hamano
2020-02-13 18:00       ` Taylor Blau
2020-02-13 18:10         ` Junio C Hamano
2020-02-13 18:52           ` Jeff King
2020-02-15  0:00             ` Taylor Blau
2020-02-12 19:19 ` [PATCH 3/5] object.c: parse_object_or_die() " Parth Gala via GitGitGadget
2020-02-12 19:19 ` [PATCH 4/5] object.c: clear_object_flags() " Parth Gala via GitGitGadget
2020-02-12 19:19 ` [PATCH 5/5] object.c: clear_commit_marks_all() " Parth Gala via GitGitGadget
2020-02-12 20:18 ` [PATCH 0/5] object.c: localize global the_repository variable into r Taylor Blau
2020-02-13  5:14   ` parth gala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1e4da02-9411-8a93-ca62-6d7ae7bf4ae8@gmail.com \
    --to=parthpgala@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git