From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 39CEE1F4D8 for ; Sun, 8 May 2022 15:45:39 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lFfZ1/Gt"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235076AbiEHPsT (ORCPT ); Sun, 8 May 2022 11:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235064AbiEHPsQ (ORCPT ); Sun, 8 May 2022 11:48:16 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB0162AF4 for ; Sun, 8 May 2022 08:44:25 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id t16so9416510qtr.9 for ; Sun, 08 May 2022 08:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7KXla6N0fh0hom5EGKZIIgAuxFqdeSmaEg06H2VQegg=; b=lFfZ1/GtrrfbXX+2FXFb02SZojLJ4dfQuC0uJIbiCLRz2FSdtRhho14kWRTGTkrqUX pD8OdX1q0ybWuojg5xB2wydzfrFciPmJscmCKfkIJn72SjhM555TnNGKsEAyk51Uv2HM dHGNfZ2p6roYHC87wdzRPKvD/SVIkHMyiUO4O4FntJSrsTvwaj0Oo+QRrU+I1LObSxDI y/bbt7sPIA5XTjZB5cbYa/svYIQueZcw9frV1aJgb5U5V0SklpWItDDxSECLPXaVqOOS 0MOXUQZKh8RNUJXS8u95jAYuAGtmMvLMQ3/Soavk+1rKRtqle27/S5Pa5rJVjcf7bUJG WZNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7KXla6N0fh0hom5EGKZIIgAuxFqdeSmaEg06H2VQegg=; b=JjaLzaLsSRzjM0tPHlrRsVaLJy5HkpG7NXTCm+0kQDomeZjJ4ov6yVhS5/cJiOsPOm h0EiZPnTptoIt2csW0zRhadkDJLA+fYU6sfxf8w78AwqP8usMY4oAMY2/UiK2mduInvG g7Vrna7HM/PiQsdLcVhn7nNc5xOdBvlEPSbdrOOwv3UT8jE8zhpmSE4hDCED3reM2B94 XcAx/C7HVwQ13XnZZWhGOz3nFiu5+vOsmcmkdOJqnkvXSEbyuWDIW/glE+i6x1ii/AtY gkpA/P7T1MzDT8suvvwHcKpWn8ftrBbrCUhPo4nEJNp/EjQbc6qESOy5aRjYmoK8yCUu ZBcg== X-Gm-Message-State: AOAM530nocWgDa+Bq4IL+6eDxg5IC4D9tOd5Git2ZXd5yib7BMBPLwFH jOy9SPHpp1JYlYsWsvpEAIs= X-Google-Smtp-Source: ABdhPJyhhnS6ZNxiqxzvZ87FObXhwkMxQB2XAsMMuB9FjHLE3087Mfi8TKmneMFYWaPNN2BoW+ning== X-Received: by 2002:a05:622a:1aa1:b0:2f3:b4b0:6fc8 with SMTP id s33-20020a05622a1aa100b002f3b4b06fc8mr11771984qtc.430.1652024664933; Sun, 08 May 2022 08:44:24 -0700 (PDT) Received: from [192.168.1.127] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id x8-20020ac87a88000000b002f39b99f6b1sm5974156qtr.75.2022.05.08.08.44.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 08:44:24 -0700 (PDT) Subject: Re: [PATCH v3] builtin/remote.c: teach `-v` to list filters for promisor remotes To: Abhradeep Chakraborty via GitGitGadget , git@vger.kernel.org Cc: Philip Oakley , Junio C Hamano , Abhradeep Chakraborty References: From: Philippe Blain Message-ID: Date: Sun, 8 May 2022 11:44:23 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Forgot to comment on the patch itself :P Le 2022-05-07 à 10:20, Abhradeep Chakraborty via GitGitGadget a écrit : > From: Abhradeep Chakraborty > > Documentation/git-remote.txt | 3 +++ > builtin/remote.c | 18 +++++++++++++----- > t/t5616-partial-clone.sh | 28 ++++++++++++++++++++++++++++ I think the tests woud fit better in t5505-remote.sh, since the patch really adds a feature to the 'git remote' command. > 3 files changed, 44 insertions(+), 5 deletions(-) > > diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt > index cde9614e362..a125bd839f7 100644 > --- a/Documentation/git-remote.txt > +++ b/Documentation/git-remote.txt > @@ -35,6 +35,9 @@ OPTIONS > -v:: > --verbose:: > Be a little more verbose and show remote url after name. > + For promisor remotes it will show an extra information I found it sligtly awkward to use the future tense here. Maybe just: For promisor remotes, also show which filter (`blob:none` etc.) that promisor remote use, wrapped in square brackets. And technically, it's not really the remote that "uses" the filter, but more the local Git client. So maybe something like this would be more accurate and simpler: For promisor remotes, also show which filter (`blob:none` etc.) are configured, wrapped in square brackets. And even then "wrapped in square brackets" *could* be dropped, I think. Apart from that, the patch and test look good, thanks for working on that! Cheers, Philippe.