From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>, Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC v1 1/1] Use size_t instead of unsigned long
Date: Mon, 19 Nov 2018 06:33:30 +0100 [thread overview]
Message-ID: <f0c0e2e8-717d-9973-5533-8b806474e119@web.de> (raw)
In-Reply-To: <xmqqwopadkf9.fsf@gitster-ct.c.googlers.com>
On 2018-11-19 00:40, Junio C Hamano wrote:
> Derrick Stolee <stolee@gmail.com> writes:
>
>>> This needs to go on top of pu, to cover all the good stuff
>>> cooking here.
>>
>> Better to work on top of 'master', as the work in 'pu' will be
>> rewritten several times, probably.
>
> We may not be able to find any good moment to update some codepaths
> with deep callchains that reaches a basic API function that take
> ulong that way, as things are always in motion, but hopefully a lot
> of areas that need changes are rather isolated.
>
> For example, the changes I see around "offset" (which is "ulong" and
> the patch wants to change it to "size_t") in archive-tar.c in the
> patch do not have any interaction with the changes in this patch
> outside that single file, and I do not think any topic in-flight
> would interact with this change badly, either. I didn't carefully
> look at the remainder of the patches, but I have a feeling that many
> can be separated out into independent and focused set of smaller
> patches that can be evaluated on their own.
>
The archive-tar.c is actually a good example, why a step-by-step update
is not ideal (the code would not work any more on Win64).
If we look here:
static int stream_blocked(const struct object_id *oid)
{
struct git_istream *st;
enum object_type type;
size_t sz;
char buf[BLOCKSIZE];
ssize_t readlen;
st = open_istream(oid, &type, &sz, NULL);
^^^^^
if (!st)
return error(_("cannot stream blob %s"), oid_to_hex(oid));
for (;;) {
The sz variable must follow whatever open_istream() uses, so if we start
with archive-tar.c, we must use either size_t or ulong, whatever
open_istream() needs. Otherwise things will break:
archive-tar.c uses ulong, open_istream() size_t, but we are passing pointers
around, and here &ulong != &size_t
If we only update open_istream(), but not archive-tar.c, then
things are not better:
&size_t != &ulong.
I don't have a good idea how to split the patch.
However, "add a coccinelle script" may be a solution.
next prev parent reply other threads:[~2018-11-19 5:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 15:11 [PATCH/RFC v1 1/1] Use size_t instead of unsigned long tboegi
2018-11-18 20:18 ` Derrick Stolee
2018-11-18 23:40 ` Junio C Hamano
2018-11-19 5:33 ` Torsten Bögershausen [this message]
2018-11-19 18:15 ` René Scharfe
2018-11-19 16:33 ` Torsten Bögershausen
2018-11-20 1:36 ` Junio C Hamano
2018-11-20 5:04 ` [PATCH v2 1/1] Use size_t instead of 'unsigned long' for data in memory tboegi
2018-11-21 11:55 ` Derrick Stolee
2019-01-16 21:46 ` Thomas Braun
2019-01-19 17:06 ` Torsten Bögershausen
2019-01-22 14:25 ` Thomas Braun
2019-04-13 15:18 ` [PATCH v3 " tboegi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c0e2e8-717d-9973-5533-8b806474e119@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).