From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] headers: normalize the spelling of some header guards
Date: Mon, 15 Oct 2018 01:38:14 +0100 [thread overview]
Message-ID: <f04c2f71-fe0f-a935-d49d-c71684b7558c@ramsayjones.plus.com> (raw)
In-Reply-To: <20181014235950.GA13510@sigill.intra.peff.net>
On 15/10/18 00:59, Jeff King wrote:
> On Sun, Oct 14, 2018 at 09:13:09PM +0100, Ramsay Jones wrote:
>
>> This patch is marked RFC because I am not aware of any policy with
>> regard to header guard spelling. Having said that, apart from the
>> fetch-negotiator.h header, all of these headers are using a reserved
>> identifier (see C99 Standard 7.1.3).
>>
>> These headers were found, thus:
>>
>> $ git grep -n -E '^#ifn?def ' -- '*.h' | grep 'h\:1\:' | grep -v '^compat' | grep -v -E '[A-Z_]*_H$'
>> alias.h:1:#ifndef __ALIAS_H__
>> commit-reach.h:1:#ifndef __COMMIT_REACH_H__
>> fetch-negotiator.h:1:#ifndef FETCH_NEGOTIATOR
>> midx.h:1:#ifndef __MIDX_H__
>> t/helper/test-tool.h:1:#ifndef __TEST_TOOL_H__
>> vcs-svn/fast_export.h:1:#ifndef FAST_EXPORT_H_
>> vcs-svn/line_buffer.h:1:#ifndef LINE_BUFFER_H_
>> vcs-svn/sliding_window.h:1:#ifndef SLIDING_WINDOW_H_
>> vcs-svn/svndiff.h:1:#ifndef SVNDIFF_H_
>> vcs-svn/svndump.h:1:#ifndef SVNDUMP_H_
>
> I think the ones with a trailing underscore are actually OK according to
> the standard (not sure if your "all of these" was including the ones in
> vcs-svn ;) ).
Yes, trailing underscore is fine - "all of these" meant the
headers in the patch, with the noted exception of fetch-negotiator.h.
> I'm in favor of normalizing even the ones that aren't illegal, though
> I'm OK either way on the vcs-svn bits if they're going away anyway.
I wasn't sure about vcs-svn, but assumed that they might go
away soon (hence the cc: list). I will be happy to add them
to the patch, if that is not the case.
Thanks.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2018-10-15 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 20:13 [RFC/PATCH] headers: normalize the spelling of some header guards Ramsay Jones
2018-10-14 23:17 ` brian m. carlson
2018-10-14 23:59 ` Jeff King
2018-10-15 0:38 ` Ramsay Jones [this message]
2018-10-15 3:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f04c2f71-fe0f-a935-d49d-c71684b7558c@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).