From: Johannes Sixt <j6t@kdbg.org>
To: randall.s.becker@rogers.com
Cc: git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [Fix v2] t5562: remove dependency on /dev/zero
Date: Sat, 9 Feb 2019 09:46:12 +0100 [thread overview]
Message-ID: <f01141d4-e77e-24ba-2354-e7aebc2c3c57@kdbg.org> (raw)
In-Reply-To: <20190208220751.9936-1-randall.s.becker@rogers.com>
Am 08.02.19 um 23:07 schrieb randall.s.becker@rogers.com:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> Replaced subtest 15 (CONTENT_LENGTH overflow ssite_t) use of /dev/zero
> with yes and a translation of its result to a stream of NULL. This is
> a more portable solution.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> t/t5562-http-backend-content-length.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh
> index 90d890d02..b8d1913e5 100755
> --- a/t/t5562-http-backend-content-length.sh
> +++ b/t/t5562-http-backend-content-length.sh
> @@ -143,14 +143,14 @@ test_expect_success GZIP 'push gzipped empty' '
>
> test_expect_success 'CONTENT_LENGTH overflow ssite_t' '
> NOT_FIT_IN_SSIZE=$(ssize_b100dots) &&
> - env \
> + yes | tr "y" "\\0" | env \
> CONTENT_TYPE=application/x-git-upload-pack-request \
> QUERY_STRING=/repo.git/git-upload-pack \
> PATH_TRANSLATED="$PWD"/.git/git-upload-pack \
> GIT_HTTP_EXPORT_ALL=TRUE \
> REQUEST_METHOD=POST \
> CONTENT_LENGTH="$NOT_FIT_IN_SSIZE" \
> - git http-backend </dev/zero >/dev/null 2>err &&
> + git http-backend >/dev/null 2>err &&
> grep "fatal:.*CONTENT_LENGTH" err
> '
How many bytes are needed here? yes() in test-lib.sh generates only 99
'y', if I am not mistaken.
-- Hannes
next prev parent reply other threads:[~2019-02-09 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 22:07 [Fix v2] t5562: remove dependency on /dev/zero randall.s.becker
2019-02-08 22:37 ` Jeff King
2019-02-08 23:38 ` Junio C Hamano
2019-02-09 17:00 ` Randall S. Becker
2019-02-09 8:46 ` Johannes Sixt [this message]
2019-02-09 18:25 ` Junio C Hamano
2019-02-09 19:07 ` Randall S. Becker
2019-02-09 21:54 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01141d4-e77e-24ba-2354-e7aebc2c3c57@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).