* [PATCH] gitweb: Add snapshot to log; remove redundant commit from log
@ 2006-09-28 23:50 Luben Tuikov
2006-09-29 2:29 ` Junio C Hamano
2006-10-03 9:12 ` Jakub Narebski
0 siblings, 2 replies; 3+ messages in thread
From: Luben Tuikov @ 2006-09-28 23:50 UTC (permalink / raw
To: git
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
This removes redundant "commit" from log in favor of adding
"snapshot". The commit can be had by clicking on the title of
the entry.
From commit | commitdiff | tree
To commitdiff | tree | snapshot
This makes it consistent with "shortlog".
Adding "snapshot" without removing redundant "commit" makes
it too messy as the log gets out of visual alignment.
I'm ambivalent whether this goes in or not.
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
[-- Attachment #2: 458135609-p5.txt --]
[-- Type: text/plain, Size: 821 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 953a0ef..9052647 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2887,11 +2887,11 @@ sub git_log {
$commit);
print "<div class=\"title_text\">\n" .
"<div class=\"log_link\">\n" .
- $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") .
- " | " .
$cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") .
" | " .
$cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
+ " | " .
+ $cgi->a({-href => href(action=>"snapshot", hash=>$commit)}, "snapshot") .
"<br/>\n" .
"</div>\n" .
"<i>" . esc_html($co{'author_name'}) . " [$ad{'rfc2822'}]</i><br/>\n" .
--
1.4.2.1.g05f0f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: Add snapshot to log; remove redundant commit from log
2006-09-28 23:50 [PATCH] gitweb: Add snapshot to log; remove redundant commit from log Luben Tuikov
@ 2006-09-29 2:29 ` Junio C Hamano
2006-10-03 9:12 ` Jakub Narebski
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2006-09-29 2:29 UTC (permalink / raw
To: ltuikov; +Cc: git
Luben Tuikov <ltuikov@yahoo.com> writes:
> Adding "snapshot" without removing redundant "commit" makes
> it too messy as the log gets out of visual alignment.
>
> I'm ambivalent whether this goes in or not.
I admit I was who suggested "we might want to", but I agree this
is going a bit too far.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: Add snapshot to log; remove redundant commit from log
2006-09-28 23:50 [PATCH] gitweb: Add snapshot to log; remove redundant commit from log Luben Tuikov
2006-09-29 2:29 ` Junio C Hamano
@ 2006-10-03 9:12 ` Jakub Narebski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Narebski @ 2006-10-03 9:12 UTC (permalink / raw
To: git
Luben Tuikov wrote:
> This removes redundant "commit" from log in favor of adding
> "snapshot".
"Snapshot" link should be added gitweb_have_snapshot conditionally.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-03 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-28 23:50 [PATCH] gitweb: Add snapshot to log; remove redundant commit from log Luben Tuikov
2006-09-29 2:29 ` Junio C Hamano
2006-10-03 9:12 ` Jakub Narebski
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).