From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id BBF481F626 for ; Thu, 23 Feb 2023 09:15:39 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=GSwqfxNs; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233902AbjBWJPh (ORCPT ); Thu, 23 Feb 2023 04:15:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233892AbjBWJP2 (ORCPT ); Thu, 23 Feb 2023 04:15:28 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B4BD497D1 for ; Thu, 23 Feb 2023 01:15:11 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id v3so9992541wrp.2 for ; Thu, 23 Feb 2023 01:15:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=TDo59bBPiRzBnM6vJCvYq4gUWR3UC2XRfjdGAdghZ0E=; b=GSwqfxNsWCzpX3jV+D0HJDBknw5n9ELGx7rS9dr8rkNHdV5f7LIOdPsb7/Oq2+Y0wy wkZhMBHBwrb6GoFKUvrnVkXK2BuCAQipjx4yf3TywGX7y+9nLZohQVNADhpQxSP7DDiu zBd96WMMgPyl5CqEFutizIQoJFEOADgK8PhMIFiDCuWz0cUZnQrPQ84F2MWtkXCZR5kY HbHx1pSzgtI4KGuh5omQKgK+oN8X6XGxaQXj786DWDXLJHf2h2v8ajA4k1EpxDGf8Qb5 SCVHXvWq24UP6zn39k7FJzv+Q4C4e0uLLGLauOW0KIsA82iCZ+UXrn2VjJCiLSSSwN8Q 96/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TDo59bBPiRzBnM6vJCvYq4gUWR3UC2XRfjdGAdghZ0E=; b=bWOnP5ZxNRE0tZJUnrl3pbfhnlo+3XGNduHblAcoSWkv/J70ZKhyxUY50hT4aIB0CY sHuBu7MAEIoVTNHX44vBQ3oVANH4YCet60sHYtZkeB7E7pFUjPsIcd9CPkwMdW/0ZWMm cE9WyF5Bl0k4tbCIprPNWywunNiKwb3zKm24f82mozGVT7XdHmEH1HfZq6wNsA2VVYJO ckqnrwlEdSt77AnjQ2rajifq2f6ebAWsrrghUq7bra++ehdY4eErDoI1EXVCdn5moTgo 0mN1PDQCwVjOvCA4A5v/BVnFRm4ZTBMOjnRsPxhRL8edZtgpoo0CGpuheeqjWVwf07aa a7ZA== X-Gm-Message-State: AO0yUKVi8WfKwjOJOQq9xOEYOp6GoWeFVArtJnaiueXZ2EWM+0BsDa5/ 4pC3oyhGw4yVKFoZz8dG3d/Hx56mMOA= X-Google-Smtp-Source: AK7set/TowFBAi0avoDvQHTxou0OyH1d63hMtxi+TrLXzIXAcMOLdeskBfwysmVZd8+z6jSSfPlYlQ== X-Received: by 2002:a5d:68c8:0:b0:2c5:a742:572f with SMTP id p8-20020a5d68c8000000b002c5a742572fmr7857937wrw.49.1677143709846; Thu, 23 Feb 2023 01:15:09 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id e6-20020a5d5006000000b002c57384dfe0sm11735591wrt.113.2023.02.23.01.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:15:09 -0800 (PST) Message-Id: In-Reply-To: References: From: "Elijah Newren via GitGitGadget" Date: Thu, 23 Feb 2023 09:15:00 +0000 Subject: [PATCH 11/11] unpack-trees: add usage notices around df_conflict_entry Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Elijah Newren Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Elijah Newren Avoid making users believe they need to initialize df_conflict_entry to something (as happened with other output only fields before) with a quick comment and a small sanity check. Signed-off-by: Elijah Newren --- unpack-trees.c | 2 ++ unpack-trees.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/unpack-trees.c b/unpack-trees.c index 60b6e38fd69..583132f1510 100644 --- a/unpack-trees.c +++ b/unpack-trees.c @@ -1876,6 +1876,8 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options BUG("o->internal.dir is for internal use only"); if (o->internal.pl) BUG("o->internal.pl is for internal use only"); + if (o->df_conflict_entry) + BUG("o->df_conflict_entry is an output only field"); trace_performance_enter(); trace2_region_enter("unpack_trees", "unpack_trees", the_repository); diff --git a/unpack-trees.h b/unpack-trees.h index e8737adfeda..61c06eb7c50 100644 --- a/unpack-trees.h +++ b/unpack-trees.h @@ -78,7 +78,7 @@ struct unpack_trees_options { int head_idx; - struct cache_entry *df_conflict_entry; + struct cache_entry *df_conflict_entry; /* output only */ void *unpack_data; struct index_state *dst_index; -- gitgitgadget