From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-5.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id ED9261F953 for ; Mon, 29 Nov 2021 23:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231776AbhK2XR3 (ORCPT ); Mon, 29 Nov 2021 18:17:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbhK2XRP (ORCPT ); Mon, 29 Nov 2021 18:17:15 -0500 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6201C04CBE3 for ; Mon, 29 Nov 2021 15:01:57 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id x6so23481679iol.13 for ; Mon, 29 Nov 2021 15:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QzoF8DQ0B1eWDvTMjztB6U3C+0s4/dzM/uXGEAw1eNI=; b=eNrGvHmK9xelCOunZYBtkboOEbb0rrrPJJCFUEwmmf8yInFodhjhvFNV2ZyUdwDZP9 II75miDwA19Sxvy/YqCQYYR2d8Y3Wukrjt8F1VX+60apaEsNZUkgIU9oCJyNQWY2T61X fLI/0dNwrPfuAyc7uLZ1+gYBjEBHqgv7TvMAVcy4YqmKtfhtACxy5Ks4G+ztOjVtvNfa LA7nHRbXXYYrdrAKMaYGuf6vIebgkPrMmaR35uoCJsIKCKMHJy29+tNMbcr3v3zpJs5I LvSTvDeSgaCo8gXryZwl4gVDBZ8gU80lyFjHmCyE+Dhm0tB15Qa05gJeah8SI8DzJz3f jvAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QzoF8DQ0B1eWDvTMjztB6U3C+0s4/dzM/uXGEAw1eNI=; b=xgvLJEDdktDsux8EqBVPoT2fgKtuGHN61b67ctYJtbWxY9doQKSEoSQpfFTnzBYtRO 3s1aKlxd2U0/jLBbFDQKAbA2uco62zu9FEpeiGZ00tpLFYcKmK+8Id03TN5DHJGXlhFQ Ge0BUxRGrPy8fXu+FOSmV6iYm1X7BSM6pbaeVXrA6/h1HJ2GKpM69j32ItZRZag7G2cR QjQNkwX6oNbcAm7tLl5+BSQECCdql+g3Bpr4mXiLYdhN94K4Cv98R4gmWEoDxWOYO9Zm ECfwAwO7xyyKoqotou8khYBHiFpgTJG637SqjRpGTnjr60LKmbsgG2Xdon+Sv0Uw1xiH yBcQ== X-Gm-Message-State: AOAM531JvtsRb2QxaLfuvKCYP2+GEgWeQIlcp658nKaTwJylTEqwRKSt OvGog2ttczp4WzXE7O5dSko= X-Google-Smtp-Source: ABdhPJxzW3ZOf9rdALfMe+0PsIeQfmar12bIkStP+e7gef7VZsRE6UZP1+nbrKT/Uow2S7KkHerqSg== X-Received: by 2002:a6b:f70e:: with SMTP id k14mr56677305iog.173.1638226917190; Mon, 29 Nov 2021 15:01:57 -0800 (PST) Received: from [192.168.86.121] (097-087-102-211.res.spectrum.com. [97.87.102.211]) by smtp.gmail.com with ESMTPSA id x2sm8572954ilv.65.2021.11.29.15.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Nov 2021 15:01:56 -0800 (PST) Message-ID: Date: Mon, 29 Nov 2021 15:01:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v4 2/4] test-read-cache: set up repo after git directory Content-Language: en-US To: Junio C Hamano Cc: Lessley Dennington via GitGitGadget , git@vger.kernel.org, stolee@gmail.com, newren@gmail.com, Taylor Blau References: <5bc5e8465ab5fe871965e6c6d578efc51e55b505.1637620958.git.gitgitgadget@gmail.com> <0372ee0b-8dda-c505-2b83-30da74e4fb36@gmail.com> From: Lessley Dennington In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 11/24/21 10:36 AM, Junio C Hamano wrote: > Lessley Dennington writes: > >> On 11/23/21 3:42 PM, Junio C Hamano wrote: >>> "Lessley Dennington via GitGitGadget" >>> writes: >>> >>>> From: Lessley Dennington >>>> >>>> Move repo setup to occur after git directory is set up. This will ensure >>>> enabling the sparse index for `diff` (and guarding against the nongit >>>> scenario) will not cause tests to start failing, since that change will include >>>> adding a check to prepare_repo_settings() with the new BUG. > >>> This looks obviously the right thing to do. Would anything break >>> because of the "wrong" ordering of events in the original code? >>> IOW, can this "bugfix" be protected with a new test against >>> regression? >>> >> Yep! Tests 2, 3, 28, and 34 in t1092-sparse-checkout-compatibility.sh >> will fail without this change. > > I do not understand. When 1/4 and 2/4 are applied, no tests in > t1092 fail for me. > > I think the presentation order of this series is not reviewer > friendly; "the new BUG" is introduced in a separate step and > obscures the reason why this step is needed. It is better than > adding "the new BUG" first and let some tests fail and then fix the > breakage the series caused in later steps, though. > > > > What I meant was that those tests fail with the first patch in the series. Once this patch is applied they no longer fail. That being said, I agree with this feedback - I have reorganized the changes for v5 in a way in which I hope will make more sense and will improve the reviewer experience. Lessley