From: Baruch Siach <baruch@tkos.co.il>
To: git@vger.kernel.org
Cc: Baruch Siach <baruch@tkos.co.il>, Joe Perches <joe@perches.com>,
Rasmus Villemoes <rv@rasmusvillemoes.dk>
Subject: [PATCH] send-email: don't cc *-by lines with '-' prefix
Date: Sat, 16 Mar 2019 21:26:50 +0200 [thread overview]
Message-ID: <eec56beab016182fb78fbd367fcfa97f2ca6a5ff.1552764410.git.baruch@tkos.co.il> (raw)
Since commit ef0cc1df90f6b ("send-email: also pick up cc addresses from
-by trailers") in git version 2.20, git send-email adds to cc list
addresses from all *-by lines. As a side effect a line with
'-Signed-off-by' is now also added to cc. This makes send-email pick
lines from patches that remove patch files from the git repo. This is
common in the Buildroot project that often removes (and adds) patch
files that have 'Signed-off-by' in their patch description part.
Consider only *-by lines that start with [a-z] (case insensitive) to
avoid unrelated addresses in cc.
Cc: Joe Perches <joe@perches.com>
Cc: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
git-send-email.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 8eb63b5a2f8d..5656ba83d9b1 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1693,7 +1693,7 @@ sub process_file {
# Now parse the message body
while(<$fh>) {
$message .= $_;
- if (/^([a-z-]*-by|Cc): (.*)/i) {
+ if (/^([a-z][a-z-]*-by|Cc): (.*)/i) {
chomp;
my ($what, $c) = ($1, $2);
# strip garbage for the address we'll use:
--
2.20.1
next reply other threads:[~2019-03-16 19:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 19:26 Baruch Siach [this message]
2019-03-16 19:30 ` [PATCH] send-email: don't cc *-by lines with '-' prefix Joe Perches
2019-03-16 19:49 ` Baruch Siach
2019-03-16 19:59 ` Joe Perches
2019-03-16 20:14 ` Baruch Siach
2019-03-16 20:23 ` Joe Perches
2019-03-17 19:27 ` Rasmus Villemoes
2019-03-18 1:56 ` Joe Perches
2019-03-18 6:28 ` Junio C Hamano
2019-03-18 7:02 ` Joe Perches
2019-04-04 7:38 ` Baruch Siach
2019-04-04 9:20 ` Junio C Hamano
2019-04-04 9:27 ` Baruch Siach
2019-04-04 9:41 ` Junio C Hamano
2019-04-04 9:42 ` Rasmus Villemoes
2019-04-04 9:47 ` Junio C Hamano
2019-04-04 12:14 ` Jeff King
2019-04-04 9:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec56beab016182fb78fbd367fcfa97f2ca6a5ff.1552764410.git.baruch@tkos.co.il \
--to=baruch@tkos.co.il \
--cc=git@vger.kernel.org \
--cc=joe@perches.com \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).