git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "David Symonds" <dsymonds@gmail.com>
To: "Petr Baudis" <pasky@suse.cz>
Cc: git@vger.kernel.org, jnareb@gmail.com, ltuikov@yahoo.com
Subject: Re: [ANNOUNCE] git/gitweb.git repository
Date: Fri, 31 Aug 2007 10:56:32 +1000	[thread overview]
Message-ID: <ee77f5c20708301756k60b4d295j907da463af477982@mail.gmail.com> (raw)
In-Reply-To: <20070831000149.GK1219@pasky.or.cz>

On 31/08/2007, Petr Baudis <pasky@suse.cz> wrote:
>   Please feel encouraged to make random forks for your development
> efforts, or push your random patches (preferrably just bugfixes,
> something possibly controversial should be kept in safe containment like
> a fork or separate branch) to the mob branch.

Sorry, I'm still relatively new to git, and couldn't work out how to
push to the mob branch, so it's inline below. It's fairly minor, just
adding <span title="foo">..</span> around author names when they get
abbreviated.


Dave.


>From 37c85462393d3e83d83dbdc9362cd9ff7587574c Mon Sep 17 00:00:00 2001
From: David Symonds <dsymonds@gmail.com>
Date: Fri, 31 Aug 2007 10:49:53 +1000
Subject: [PATCH] gitweb: Provide title attributes for abbreviated author names.

Signed-off-by: David Symonds <dsymonds@gmail.com>
---
 gitweb/gitweb.perl |   34 +++++++++++++++++++++++++++++-----
 1 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b2bae1b..3112fd4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3461,9 +3461,15 @@ sub git_shortlog_body {
 			print "<tr class=\"light\">\n";
 		}
 		$alternate ^= 1;
+		my $author = chop_str($co{'author_name'}, 10);
+		if ($author ne $co{'author_name'}) {
+			$author = "<span title=\"$co{'author_name'}\">" .
esc_html($author) . "</span>";
+		} else {
+			$author = esc_html($author);
+		}
 		# git_summary() used print "<td><i>$co{'age_string'}</i></td>\n" .
 		print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n"
.
-		      "<td><i>" . esc_html(chop_str($co{'author_name'}, 10)) .
"</i></td>\n" .
+		      "<td><i>" . $author . "</i></td>\n" .
 		      "<td>";
 		print format_subject_html($co{'title'}, $co{'title_short'},
 		                          href(action=>"commit", hash=>$commit), $ref);
@@ -3511,9 +3517,15 @@ sub git_history_body {
 			print "<tr class=\"light\">\n";
 		}
 		$alternate ^= 1;
+	# shortlog uses      chop_str($co{'author_name'}, 10)
+		my $author = chop_str($co{'author_name'}, 15, 3);
+		if ($author ne $co{'author_name'}) {
+			"<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>";
+		} else {
+			$author = esc_html($author);
+		}
 		print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n"
.
-		      # shortlog uses      chop_str($co{'author_name'}, 10)
-		      "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 3)) .
"</i></td>\n" .
+		      "<td><i>" . $author . "</i></td>\n" .
 		      "<td>";
 		# originally git_history used chop_str($co{'title'}, 50)
 		print format_subject_html($co{'title'}, $co{'title_short'},
@@ -3667,8 +3679,14 @@ sub git_search_grep_body {
 			print "<tr class=\"light\">\n";
 		}
 		$alternate ^= 1;
+		my $author = chop_str($co{'author_name'}, 15, 5);
+		if ($author ne $co{'author_name'}) {
+			$author = "<span title=\"$co{'author_name'}\">" .
esc_html($author) . "</span>";
+		} else {
+			$author = esc_html($author);
+		}
 		print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n"
.
-		      "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) .
"</i></td>\n" .
+		      "<td><i>" . $author . "</i></td>\n" .
 		      "<td>" .
 		      $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}),
-class => "list subject"},
 			       esc_html(chop_str($co{'title'}, 50)) . "<br/>");
@@ -5181,8 +5199,14 @@ sub git_search {
 						print "<tr class=\"light\">\n";
 					}
 					$alternate ^= 1;
+					my $author = chop_str($co{'author_name'}, 15, 5);
+					if ($author ne $co{'author_name'}) {
+						$author = "<span title=\"$co{'author_name'}\">" .
esc_html($author) . "</span>";
+					} else {
+						$author = esc_html($author);
+					}
 					print "<td
title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n"
.
-					      "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5))
. "</i></td>\n" .
+					      "<td><i>" . $author . "</i></td>\n" .
 					      "<td>" .
 					      $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}),
 					              -class => "list subject"},
-- 
1.5.2.4

  reply	other threads:[~2007-08-31  0:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31  0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis
2007-08-31  0:56 ` David Symonds [this message]
2007-08-31  1:00   ` David Symonds
2007-09-01  5:46   ` David Symonds
2007-09-07  6:39     ` David Symonds
2007-09-01  1:06 ` Luben Tuikov
2007-09-01  1:16   ` Petr Baudis
2007-09-01  1:23     ` Luben Tuikov
2007-09-01  1:25   ` Johannes Schindelin
2007-09-01  1:31     ` Petr Baudis
2007-09-01  1:44       ` Junio C Hamano
2007-09-01  2:15         ` Luben Tuikov
2007-09-01  4:57           ` Junio C Hamano
2007-09-01  2:06     ` Luben Tuikov
2007-09-01 15:15 ` Jon Smirl
2007-09-01 17:54   ` Junio C Hamano
2007-09-01 17:54 ` Jakub Narebski
2007-09-04  5:42 ` Junio C Hamano
2007-09-04  5:47   ` Adam Roben
2007-09-04  5:50   ` Shawn O. Pearce
2007-09-04  8:19     ` Junio C Hamano
2007-09-04  5:58   ` Andreas Ericsson
2007-09-04  9:38     ` Petr Baudis
2007-09-04  7:56   ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee77f5c20708301756k60b4d295j907da463af477982@mail.gmail.com \
    --to=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=ltuikov@yahoo.com \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).