From: Ernst Reissner <rei3ner@arcor.de>
To: git@vger.kernel.org
Subject: bug report/feature request: git describe: what is 'clean'
Date: Tue, 1 Dec 2020 11:46:35 +0100 [thread overview]
Message-ID: <ed404c7e-d098-348d-d8fe-dae8aa5a5fda@arcor.de> (raw)
Hello All,
find below a bug report/feature request.
Regards,
Ernst
Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.
What did you do before the bug happened? (Steps to reproduce your issue)
i have a workspace with untracked files, else clean.
then i did `git describe`.
What did you expect to happen? (Expected behavior)
I expected to see a label 'dirty'
What happened instead? (Actual behavior)
no label `dirty`
What's different between what you expected and what actually happened?
obvious
Anything else you want to add:
I know that this is not precisely a bug,
Instead it is a feature request.
Practically, `git describe` is used to determine a version.
For me the sense of 'dirty' is to indicate that this deliverable is not
reproducible from the repo.
Thus it may not be delivered to a customer.
So in this sense, untracked files make a workspace dirty also.
Without the need of backward compatibility, i would say, dirty is all,
which is tracked and modified staged or not,
or which is untracked but not ignored.
To keep backward compatibility,
maybe it is a good idea to add a second suffix, maybe 'untracked' to
display in addition.
That way it is clear: only if no suffix is present, software from repo
can be delivered
and one is sure that this is reproducible.
Please review the rest of the bug report below.
You can delete any lines you don't wish to share.
[System Info]
git version:
git version 2.29.2
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
uname: Linux 5.9.1-2-default #1 SMP Mon Oct 26 07:02:23 UTC 2020
(435e92d) x86_64
compiler info: gnuc: 10.2
libc info: glibc: 2.32
$SHELL (typically, interactive shell): /bin/bash
next reply other threads:[~2020-12-01 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 10:46 Ernst Reissner [this message]
2020-12-01 20:03 ` bug report/feature request: git describe: what is 'clean' Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed404c7e-d098-348d-d8fe-dae8aa5a5fda@arcor.de \
--to=rei3ner@arcor.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).