Git Stash Creates sh.exe.stackdump (STATUS_STACK_OVERFLOW)

Git Stash Creates sh.exe.stackdump (STATUS_STACK_OVERFLOW)

[Derek Foulk]

Hi,

An issue has arisen sometime between 2.16.1.windows.1 and 2.16.1.windows.4 in Git.

When you execute `git stash` commands (stash/pop/apply?), a sh.exe.stackdump file is generated that contains the following:

Exception: STATUS_STACK_OVERFLOW at rip=7FFB2C324B97
rax=0000000000000010 rbx=0000000000000000 rcx=0000000000000010
rdx=000000000000000C rsi=00000000FFFFAAE0 rdi=00007FFB23B8D4F0
r8 =00000000FFFFAA18 r9 =00000000FFFFAA50 r10=00000000FFFFA000
r11=00000000FFE03E70 r12=00000000FFFFB500 r13=000000000015C000
r14=000000000000014C r15=0000000000000000
rbp=00000000FFFFAA50 rsp=00000000FFFFAA08
program=C:\Program Files\Git\usr\bin\sh.exe, pid 41552, thread unknown (0x949C)
cs=0033 ds=002B es=002B fs=0053 gs=002B ss=002B
Stack trace:
Frame        Function    Args
000FFFFAA50  7FFB2C324B97 (00000000104, 000FFFFAAC8, 7FFB2C302178, 00000000000)
000FFFFAA50  7FFB2C302277 (7FFB23B8D4F0, 7FFB23B8D4F0, 00000000001, 00000230022)
000FFFFAAC8  7FFB28D1D1F4 (7FFB2C280000, 7FFB2C3021F0, 7FFB2C2EFAE0, 7FFFFFFEFFFF)
000FFFFAC90  7FFB28D1D071 (9E09000600010000, 365AE1E0F447, 00000000023, 000FFFFADB8)
000FFFFAC90  7FFB28D1CA44 (7FFB23B8D700, 00000000000, 00000000000, 7FFB23B8D700)
000FFFFAC90  7FFB23AF03A0 (000FFFFAC90, 000FFFFADB8, 000000F3DF0, 00000091380)
000FFFFAC90  7FFB23AC37DB (000FFFFB5C0, 00000000000, 000FFFFB970, 000000F3DF0)
000FFFFB3F9  7FFB23A9E4D0 (00000000002, 000FFFFB7E8, 00000000000, 00180010018)
00180010018  7FFB23A9CFDD (00000000000, 000FFFFB720, 00000000000, 000FFFFB7C0)
000FFFFB720  7FFB23A95543 (000FFFFB890, 000000001C8, 00000000000, 00180271780)
00000000420  7FFB28D1D7F6 (00000000001, 00000000000, 000FFFFB970, 00100000001)
00000000420  7FFB29C4E4E3 (00000000020, 00000000000, 000FFFFBAF0, 00000000001)
00000000420  001800AB022 (000FFFFBA90, 00000000000, 00000000000, 00180300748)
000FFFFBB10  001800ABBD5 (00100410FBB, 00000000000, 0060004DF10, 001004E9740)
000FFFFBD10  0018011C93B (00100410FBB, 00000000000, 0060004DF10, 001004E9740)
000FFFFBD10  00002DEE458 (00100410FBB, 00000000000, 0060004DF10, 001004E9740)
End of stack trace (more stack frames may be present)

The end result is you cannot pop your stashed changes (the .stackdump file injects itself into the stashed changes, then one is created before the pop occurs):

I've confirmed updating to the latest Git causes this to occur on three different workstations (and repositories).

I've tried downgrading to 2.15, but the issue has persisted (it did not exist prior to updating to 2.16).

Thanks,
-Derek

Environment:
Windows 10 (Fall Creators Update)
Git v2.16.1.windows.4 (Default installation options w/ Added context menu options)
Git Bash

Re: Git Stash Creates sh.exe.stackdump (STATUS_STACK_OVERFLOW)

[Johannes Schindelin]

Hi Derek,

On Fri, 16 Feb 2018, Derek Foulk wrote:

> An issue has arisen sometime between 2.16.1.windows.1 and 2.16.1.windows.4 in Git.
> 
> When you execute `git stash` commands (stash/pop/apply?), a sh.exe.stackdump file is generated that contains the following:
> 
> Exception: STATUS_STACK_OVERFLOW at rip=7FFB2C324B97
> rax=0000000000000010 rbx=0000000000000000 rcx=0000000000000010
> rdx=000000000000000C rsi=00000000FFFFAAE0 rdi=00007FFB23B8D4F0
> r8 =00000000FFFFAA18 r9 =00000000FFFFAA50 r10=00000000FFFFA000
> r11=00000000FFE03E70 r12=00000000FFFFB500 r13=000000000015C000
> r14=000000000000014C r15=0000000000000000
> rbp=00000000FFFFAA50 rsp=00000000FFFFAA08
> program=C:\Program Files\Git\usr\bin\sh.exe, pid 41552, thread unknown (0x949C)
> [...]

I saw similar reports on the Git for Windows bug tracker. Probably the
most relevant one is this here:
https://github.com/git-for-windows/git/issues/1562

In essence, the culprit there seems to be an overzealous anti-malware
called Comodo Internet Security. Maybe your setup has the same problem?

Ciao,
Johannes