From: Phillip Wood <phillip.wood123@gmail.com>
To: "Antti Keränen" <antti@keraset.fi>, "Taylor Blau" <me@ttaylorr.com>
Cc: phillip.wood@dunelm.org.uk, "Antti Keränen" <detegr@rbx.email>,
git@vger.kernel.org, "Jussi Keränen" <jussike@gmail.com>,
"Alban Gruin" <alban.gruin@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] rebase -i: Fix possibly wrong onto hash in todo
Date: Wed, 12 Aug 2020 14:59:48 +0100 [thread overview]
Message-ID: <eb3ecbc0-84aa-70fa-1893-3b16b21989a8@gmail.com> (raw)
In-Reply-To: <20200811181537.qt7jkoxy7qn3k7mo@haukka.localdomain>
Hi Antti
On 11/08/2020 19:15, Antti Keränen wrote:
> Hi Phillip and Taylor.
>
> On Tue, Aug 11, 2020 at 04:32:37PM +0100, Phillip Wood wrote:
>>> I'm not sure it's worth rearranging these lines. It probably does not matter
>>> but we could do
>>>
>>> + char shortonto[GIT_MAX_HEXSZ + 1];
>>>
>>> and then later call find_unique_abbrev_r() instead so we don't have to worry
>>> about freeing shortonto.
>
> I like this. I'll change the code, if the rest of the patch is okay.
Thanks great
Thanks
Phillip
>
>>> Thanks for taking the trouble to add a test, I think all the lines above
>>> could be simplified to
>>>
>>> GIT_SEQUENCE_EDITOR=cat git rebase -i HEAD~5 branch1 >actual
>
> Nice! :) There was a test called 'todo count' which I mimicked. This
> obviously is much cleaner solution, thanks.
>
>>> we could lose the final .*
>
> Ack.
>
> On Tue, Aug 11, 2020 at 11:36:21AM -0400, Taylor Blau wrote:
>> Ack, I noticed this too during my review, but apparently forgot to
>> comment on it. I'm puzzled by the first '..*'. If you're searching for
>> any non-empty string, how about '.+' instead?
>
> That's true. Good point. I pretty much copy&pasted the 'todo count' test
> so I didn't give this much thought. I'll fix this.
>
prev parent reply other threads:[~2020-08-12 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 13:13 [PATCH] rebase -i: Fix possibly wrong onto hash in todo Antti Keränen
2020-08-11 15:28 ` Taylor Blau
2020-08-11 18:10 ` Antti Keränen
2020-08-11 18:24 ` Taylor Blau
2020-08-11 15:32 ` Phillip Wood
2020-08-11 15:36 ` Taylor Blau
2020-08-11 18:15 ` Antti Keränen
2020-08-11 18:58 ` Junio C Hamano
2020-08-11 19:01 ` Taylor Blau
2020-08-11 19:05 ` Junio C Hamano
2020-08-12 14:03 ` Taylor Blau
2020-08-12 19:40 ` Junio C Hamano
2020-08-12 13:59 ` Phillip Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb3ecbc0-84aa-70fa-1893-3b16b21989a8@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=antti@keraset.fi \
--cc=detegr@rbx.email \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jussike@gmail.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).