From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6D3791F463 for ; Tue, 7 Jan 2020 04:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbgAGExq (ORCPT ); Mon, 6 Jan 2020 23:53:46 -0500 Received: from mail-qv1-f44.google.com ([209.85.219.44]:35029 "EHLO mail-qv1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727610AbgAGExj (ORCPT ); Mon, 6 Jan 2020 23:53:39 -0500 Received: by mail-qv1-f44.google.com with SMTP id u10so19958309qvi.2 for ; Mon, 06 Jan 2020 20:53:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IUqS2ToxxIaU+JGMqM0slg+lmdW/PYLUq2Mp3ANUqOY=; b=Jb4AjixxpucSr5IV9UcZ/aCVXZpHgvJCkRQnVZSRQWSaGjSTe8r0aoOUeTIyWZ8zzJ 0SHYa/tjXroYwOxBmNqNustqROzKlyhVDcnx9mWEYIdDXw1kDdrVOnac+seSSkcK/tjT 8Zaf8Qcf2CUmPd9ZdMjUshO1IvvUYqoMr4iO1xwfRIiBHMUI/E5oE7uvDM38Cf3RE8zx HX0CyMeDCR9I3I9MYry5w8NqvOe0oKaCgVeL6LykbEgJAjzu2adZnJdYFGIxYap03P9k MzzyREg9zpHN450aRB1SI2IOzpTU0kmLRwTP8hrRSVRTHpwcumFt8ABj8/Vw99qTsw1c nBRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IUqS2ToxxIaU+JGMqM0slg+lmdW/PYLUq2Mp3ANUqOY=; b=VPlb1pf4634Fbd2RzakSfPXahvYMsZ4/esJ458fcmDthaLqzmOh3hrzNGmh/DCPlNT B1OFusGNKxVvVYsnaJ7zKksdeWLFp01Z364984nYVXafc+qBQrS9NQRzV0Tg62mr3vsz KVUCb0d6wc3RtDYRsdJXWFRsHIG429yyq9c1DnM7JV8O4dBcY1xTvToNT4Lkugh/geMR pFIuJTdkR5Cm6EcR2r0YdBd9spIAjmP86Zn+sJg6aAcAO5wciDlDiHb73eq/T4B1jb7y 1YRn2VH9nBPYl36ZQmuu53YcOSrOKyLt3C87y9haKrJPtW2343jPtC6XCnUdTfInXrsp wThw== X-Gm-Message-State: APjAAAWQ70N2QzoxTjjmtIrSGlEQpf8j+FsckPZFouxMArTVwa6zA/FL vpEmY4/psmpxUDDQQs7nK3Raxnqe X-Google-Smtp-Source: APXvYqzuDBjJDK2qyz7Wt1vnNOY3AHc/ImW+UT4QLDD8YrIWLVViJI2XPc2rJukzHLvcAczBoLBRDA== X-Received: by 2002:a0c:ed32:: with SMTP id u18mr83085016qvq.2.1578372817976; Mon, 06 Jan 2020 20:53:37 -0800 (PST) Received: from archbookpro.lan ([199.249.110.29]) by smtp.gmail.com with ESMTPSA id t2sm21663893qkc.31.2020.01.06.20.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 20:53:37 -0800 (PST) From: Denton Liu To: Git Mailing List Cc: Eric Sunshine , Jakub Narebski , Johannes Sixt , Junio C Hamano Subject: [PATCH v2 12/16] t3419: stop losing return code of git command Date: Mon, 6 Jan 2020 23:53:09 -0500 Message-Id: X-Mailer: git-send-email 2.25.0.rc1.180.g49a268d3eb In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Fix invocation of git command so its exit codes is not lost within a non-assignment command substitution. Signed-off-by: Denton Liu --- t/t3419-rebase-patch-id.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t3419-rebase-patch-id.sh b/t/t3419-rebase-patch-id.sh index 49f548cdb9..94552669ae 100755 --- a/t/t3419-rebase-patch-id.sh +++ b/t/t3419-rebase-patch-id.sh @@ -80,7 +80,8 @@ do_tests () { git commit -q -m "change big file again" && git checkout -q other^{} && git rebase master && - test_must_fail test -n "$(git rev-list master...HEAD~)" + git rev-list master...HEAD~ >revs && + test_must_be_empty revs ' test_expect_success $pr 'do not drop patch' ' -- 2.25.0.rc1.180.g49a268d3eb