git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Johannes Sixt" <j6t@kdbg.org>,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	pudinha <rogi@skylittlesystem.org>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v2] mergetool--lib: fix '--tool-help' to correctly show available tools
Date: Wed, 6 Jan 2021 19:32:28 -0500	[thread overview]
Message-ID: <e9a1e45b-70b4-2478-1669-4308c5902c5b@gmail.com> (raw)
In-Reply-To: <xmqqeeixpsvo.fsf@gitster.c.googlers.com>



Le 2021-01-06 à 18:06, Junio C Hamano a écrit :
> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>> What was the symptom before the fix?  Is it just missing only some
>>> tools among 30?  Was there some pattern in names of missing one and
>>> the ones that still got output?  Or was it more like "we see nothing
>>> shown"?
>> ...
>> Note that 'vimdiff', 'nvimdiff3' (last variant for vimdiff),
>> 'bc' and 'bc4' (last variant for bc) are absent, and
>> all other tools that have no variants are absent as well.
> 
> Thanks, that is exactly the kind of "some pattern" I wanted to see
> us looking for, because I wonder if it is a more robust and cheaper
> (maintenance wise) approach to find one single tool that we support,
> which does not have, and which is unlikely to gain, any numbered
> variants.  If we can find such a tool, we can grep for its name in
> the output.
> 

Or, just choose a few tools, including some variants, and grep for those?
This way we are not relying on a single tool being shown for the test
to pas...

  reply	other threads:[~2021-01-07  0:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 18:22 [PATCH] mergetool--lib: fix '--tool-help' to correctly show available tools Philippe Blain via GitGitGadget
2020-12-28 19:41 ` [PATCH v2] " Philippe Blain via GitGitGadget
2021-01-06 13:16   ` SZEDER Gábor
2021-01-06 13:34     ` Philippe Blain
2021-01-06 21:15     ` Junio C Hamano
2021-01-06 22:59       ` Philippe Blain
2021-01-06 23:06         ` Junio C Hamano
2021-01-07  0:32           ` Philippe Blain [this message]
2021-01-07  1:09   ` [PATCH v3] " Philippe Blain via GitGitGadget
2021-01-07 13:37     ` Philippe Blain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9a1e45b-70b4-2478-1669-4308c5902c5b@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=l.s.r@web.de \
    --cc=rogi@skylittlesystem.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).