From: Paul Eggert <eggert@cs.ucla.edu>
To: Junio C Hamano <gitster@pobox.com>,
"Carlos L. via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Carlos L." <00xc@protonmail.com>,
GNU grep developers <grep-devel@gnu.org>
Subject: Re: [PATCH] grep: add --max-count command line option
Date: Mon, 16 May 2022 00:28:16 -0700 [thread overview]
Message-ID: <e89577f8-8f52-bf09-15f3-c534bf1a6c64@cs.ucla.edu> (raw)
In-Reply-To: <xmqqilq658b3.fsf@gitster.g>
On 5/15/22 22:57, Junio C Hamano wrote:
> It indeed is curious why GNU grep chose to immediately exit with 1
> when "-m 0" was given,
As I vaguely recall, if "-m 1" stops before "-m 2" does, then the idea
was that it's reasonable for "-m 0" to stop before "-m 1" does, and the
logical place to stop is right at the start, before any matches are
found (i.e., exit with status 1).
What would be more useful for 'grep -m 0' to do? (Sorry, I came into
this conversation just now.) Perhaps GNU 'grep -m 0' should change, if
there's something better for it to do.
> What "git grep -m -1" should do? IIRC, OPT_INTEGER is for signed
> integer but the new .max_count member, as well as the existing
> "count" that is compared with it, are of "unsigned" type. Either
> erroring out or treating it as unlimited is probably fine, but
> whatever we do, we should document and have a test for it.
'grep -m -1' treats the count as being unlimited, but this isn't
documented and (from the code) appears to be accidental. It'd make sense
for it to be documented.
next prev parent reply other threads:[~2022-05-16 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 13:20 [PATCH] grep: add --max-count command line option Carlos L. via GitGitGadget
2022-05-14 18:16 ` Martin Ågren
2022-05-16 5:57 ` Junio C Hamano
2022-05-16 7:28 ` Paul Eggert [this message]
2022-05-16 8:38 ` Carlos L.
2022-05-16 15:36 ` Junio C Hamano
2022-05-17 5:53 ` Paul Eggert
2022-05-16 15:18 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2022-06-20 15:49 Carlos L. via GitGitGadget
2022-06-20 15:57 ` Paul Eggert
2022-06-20 16:25 ` Carlos L.
2022-06-20 16:32 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e89577f8-8f52-bf09-15f3-c534bf1a6c64@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=00xc@protonmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=grep-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).