From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 77C272042F for ; Wed, 16 Nov 2016 00:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161010AbcKPAON convert rfc822-to-8bit (ORCPT ); Tue, 15 Nov 2016 19:14:13 -0500 Received: from mxo1.dft.dmz.twosigma.com ([208.77.212.183]:35855 "EHLO mxo1.dft.dmz.twosigma.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932822AbcKPAOI (ORCPT ); Tue, 15 Nov 2016 19:14:08 -0500 Received: from localhost (localhost [127.0.0.1]) by mxo1.dft.dmz.twosigma.com (Postfix) with ESMTP id F347F100078; Wed, 16 Nov 2016 00:14:05 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at twosigma.com Received: from mxo1.dft.dmz.twosigma.com ([127.0.0.1]) by localhost (mxo1.dft.dmz.twosigma.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ELABxRxbxwlT; Wed, 16 Nov 2016 00:14:05 +0000 (GMT) Received: from exmbdft8.ad.twosigma.com (exmbdft8.ad.twosigma.com [172.22.2.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mxo1.dft.dmz.twosigma.com (Postfix) with ESMTPS id E281480035; Wed, 16 Nov 2016 00:14:05 +0000 (GMT) Received: from exmbdft7.ad.twosigma.com (172.22.2.43) by exmbdft8.ad.twosigma.com (172.22.2.84) with Microsoft SMTP Server (TLS) id 15.0.1156.6; Wed, 16 Nov 2016 00:14:05 +0000 Received: from exmbdft7.ad.twosigma.com ([fe80::9966:e831:c693:7cef]) by exmbdft7.ad.twosigma.com ([fe80::9966:e831:c693:7cef%17]) with mapi id 15.00.1156.000; Wed, 16 Nov 2016 00:14:05 +0000 From: David Turner To: 'Stefan Beller' CC: "git@vger.kernel.org" , "bmwill@google.com" , "gitster@pobox.com" , "jrnieder@gmail.com" , "mogulguy10@gmail.com" Subject: RE: [PATCH 07/16] update submodules: introduce submodule_is_interesting Thread-Topic: [PATCH 07/16] update submodules: introduce submodule_is_interesting Thread-Index: AQHSP5T74+NVC+kvykSUIUJrPrZHQqDavQwQ Date: Wed, 16 Nov 2016 00:14:05 +0000 Message-ID: References: <20161115230651.23953-1-sbeller@google.com> <20161115230651.23953-8-sbeller@google.com> In-Reply-To: <20161115230651.23953-8-sbeller@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.20.60.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org > -----Original Message----- > From: Stefan Beller [mailto:sbeller@google.com] > Sent: Tuesday, November 15, 2016 6:07 PM > Cc: git@vger.kernel.org; bmwill@google.com; gitster@pobox.com; > jrnieder@gmail.com; mogulguy10@gmail.com; David Turner; Stefan Beller > Subject: [PATCH 07/16] update submodules: introduce > submodule_is_interesting > +int submodule_is_interesting(const char *path, const unsigned char > +*sha1) { This is apparently only ever (in this series) called with null_sha1. So either this arg is unnecessary, or there are bugs elsewhere in the code.