From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brandon Casey Subject: Re: [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Date: Thu, 11 Jun 2009 12:42:45 -0500 Message-ID: References: <1243106697-6424-1-git-send-email-gitster@pobox.com> <1243106697-6424-2-git-send-email-gitster@pobox.com> <4F909897-DD86-4C35-B18F-BE1CFBF06FAE@dbservice.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: git mailing list To: Tomas Carnecky X-From: git-owner@vger.kernel.org Thu Jun 11 19:43:24 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MEoJ9-0002Rh-QN for gcvg-git-2@gmane.org; Thu, 11 Jun 2009 19:43:24 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273AbZFKRnN (ORCPT ); Thu, 11 Jun 2009 13:43:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753031AbZFKRnN (ORCPT ); Thu, 11 Jun 2009 13:43:13 -0400 Received: from mail1.nrlssc.navy.mil ([128.160.35.1]:40077 "EHLO mail.nrlssc.navy.mil" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbZFKRnN (ORCPT ); Thu, 11 Jun 2009 13:43:13 -0400 Received: by mail.nrlssc.navy.mil id n5BHgka7001402; Thu, 11 Jun 2009 12:42:47 -0500 In-Reply-To: <4F909897-DD86-4C35-B18F-BE1CFBF06FAE@dbservice.com> X-OriginalArrivalTime: 11 Jun 2009 17:42:46.0275 (UTC) FILETIME=[07D26530:01C9EABC] Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Tomas Carnecky wrote: > > On Jun 11, 2009, at 7:13 PM, Brandon Casey wrote: >> Ok, great. Looks like Sun fixed the flaw that was present in the 5.8 >> compiler, and no other changes need to be made to git. To be absolutely >> sure, and if you have a moment, can you try to compile the code >> snippet at >> the end of this email? >> >> If you name the saved the code "test.c", then just compile with >> >> /opt/SUNWspro/bin/c99 -c test.c >> >> The Sun C 5.8 compiler complains like this for me: >> >> "test.c", line 12: identifier redeclared: test_func >> current : function(pointer to const struct a_struct {int b, >> array[-1] of pointer to char c}) returning pointer to void >> previous: function(pointer to const struct a_struct {int b, >> array[-1] of pointer to char c}) returning pointer to void : "test.c", >> line 4 >> c99: acomp failed for test.c >> >> If the 5.9 compiler successfully compiles it, then this new version of >> Sun's >> compiler correctly handles c99 flex arrays. > > It compiles without errors. Great. Thanks. -brandon