git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] Document dotfiles exclusion on template copy
@ 2017-02-17 23:27 Grégoire Paris
  2017-02-17 23:32 ` Grégoire PARIS
  0 siblings, 1 reply; 4+ messages in thread
From: Grégoire Paris @ 2017-02-17 23:27 UTC (permalink / raw)
  To: git; +Cc: Grégoire Paris

Since there is no dotfile in the default template directory, there was
no point in making the check for . or .. more accurate when copying. Now
that you can customize the template directory, it would make sense, but
it's actually a good thing to at this because you would not want to have
your git directory copied in every git directory that is created should
you decide to put your template directory under version control. Plus, it
might be used as a feature by people who would want to exclude some
files.

Signed-off-by: Grégoire Paris <postmaster@greg0ire.fr>
---
I hope I'm getting it right, this is my first time using format-patch and
send-email…
 Documentation/git-init.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt
index 9d27197..7605742 100644
--- a/Documentation/git-init.txt
+++ b/Documentation/git-init.txt
@@ -116,8 +116,8 @@ does not exist, it will be created.
 TEMPLATE DIRECTORY
 ------------------
 
-The template directory contains files and directories that will be copied to
-the `$GIT_DIR` after it is created.
+The template directory contains files and directories whose name do not start
+with a dot will be copied to the `$GIT_DIR` after it is created.
 
 The template directory will be one of the following (in order):
 
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Document dotfiles exclusion on template copy
  2017-02-17 23:27 [PATCH] Document dotfiles exclusion on template copy Grégoire Paris
@ 2017-02-17 23:32 ` Grégoire PARIS
  0 siblings, 0 replies; 4+ messages in thread
From: Grégoire PARIS @ 2017-02-17 23:32 UTC (permalink / raw)
  To: Grégoire Paris, git



>   
> -The template directory contains files and directories that will be copied to
> -the `$GIT_DIR` after it is created.
> +The template directory contains files and directories whose name do not start
> +with a dot will be copied to the `$GIT_DIR` after it is created.
>   
>   The template directory will be one of the following (in order):
>   
This sentence does not make any sense, I realize that now.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Document dotfiles exclusion on template copy
@ 2017-02-17 23:37 Grégoire Paris
  2017-02-17 23:59 ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Grégoire Paris @ 2017-02-17 23:37 UTC (permalink / raw)
  To: git; +Cc: Grégoire Paris

Since there is no dotfile in the default template directory, there was
no point in making the check for . or .. more accurate when copying. Now
that you can customize the template directory, it would make sense, but
it's actually a good thing to at this because you would not want to have
your git directory copied in every git directory that is created should
you decide to put your template directory under version control. Plus, it
might be used as a feature by people who would want to exclude some
files.

Signed-off-by: Grégoire Paris <postmaster@greg0ire.fr>
---
Here is a better version.
 Documentation/git-init.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt
index 9d27197..3c5a67f 100644
--- a/Documentation/git-init.txt
+++ b/Documentation/git-init.txt
@@ -116,8 +116,8 @@ does not exist, it will be created.
 TEMPLATE DIRECTORY
 ------------------
 
-The template directory contains files and directories that will be copied to
-the `$GIT_DIR` after it is created.
+Files and directories in the template directory whose name do not start with a
+dot will be copied to the `$GIT_DIR` after it is created.
 
 The template directory will be one of the following (in order):
 
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Document dotfiles exclusion on template copy
  2017-02-17 23:37 Grégoire Paris
@ 2017-02-17 23:59 ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2017-02-17 23:59 UTC (permalink / raw)
  To: Grégoire Paris; +Cc: git, Grégoire Paris

Thanks, will queue.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-17 23:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-17 23:27 [PATCH] Document dotfiles exclusion on template copy Grégoire Paris
2017-02-17 23:32 ` Grégoire PARIS
  -- strict thread matches above, loose matches on Subject: below --
2017-02-17 23:37 Grégoire Paris
2017-02-17 23:59 ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).