git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Yaacov Akiba Slama" <ya@slamail.org>
Cc: git@vger.kernel.org
Subject: Re: [QGIT4 PATCH] Add --no-color option to several calls to git
Date: Thu, 18 Oct 2007 01:38:29 +0200	[thread overview]
Message-ID: <e5bfff550710171638l26d3e55ej9dc8b38f8aee7592@mail.gmail.com> (raw)
In-Reply-To: <1192643649-18908-1-git-send-email-ya@slamail.org>

On 10/17/07, Yaacov Akiba Slama <ya@slamail.org> wrote:
> Setting "diff.color = true" in the configuration makes
> the output of several git commands use color codes.
> The color codes aren't parsed by qgit, so adds the --no-color" option
> to the calls of these git commmands.
>
> Signed-off-by: Yaacov Akiba Slama <ya@slamail.org>
> ---

Thanks for the patch I will apply probably this week-end.

Probably a point release both for qgit-2.0 and qgit-1.5.7 will be
needed. This is a new feature of git that could break current qgit.

Could you please confirm me that with this patch qgit works flawless
for you when "diff.color = true", I' m worried to push a new point
release just to discover we need to fix some more.

Thanks
Marco

  reply	other threads:[~2007-10-17 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17 17:54 [QGIT4 PATCH] Add --no-color option to several calls to git Yaacov Akiba Slama
2007-10-17 23:38 ` Marco Costalba [this message]
2007-10-18 13:41   ` Yaacov Akiba Slama
  -- strict thread matches above, loose matches on Subject: below --
2007-10-17 17:44 Yaacov Akiba Slama

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550710171638l26d3e55ej9dc8b38f8aee7592@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ya@slamail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).