From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: Possible bug in --short option of git-rev-list
Date: Sat, 21 Apr 2007 12:03:38 +0200 [thread overview]
Message-ID: <e5bfff550704210303u195c6c3cub0df34b5e862a0c5@mail.gmail.com> (raw)
In-Reply-To: <7vps5yul49.fsf@assigned-by-dhcp.cox.net>
On 4/21/07, Junio C Hamano <junkio@cox.net> wrote:
>
> Short is abbrev + verify. This is not new.
>
In my implementation I pass command line arguments first to
git-rev-parse, and the output of git-rev-parse is then used to feed
git-rev-list, that starts loading of revisions.
The problem I found is that output of git-rev-parse could be veeery
long, as example in git tree:
$ git rev-parse --all | wc
144 144 5904
When running qgit --all on a repo with hundreds of tags this could
lead to very long command line arguments for git-rev-list so to break
platform limits. One idea to *hide* this problem was to get only the
short version of a sha so to go from 40 to 7 chars and reduce command
line size of about 6 times.
Of course the *real* solution would be to pass qgit command line
arguments directly to git-rev-list and skip git-rev-parse altogether.
My question is: In case I skip git-rev-parse and feed directly
git-rev-list with command line arguments, there is some compatibility
break in current behaviour? In other words there are some command line
arguments 'args' for whom
git-rev-list args != git rev-parse args
| git rev-list
Thanks
Marco
prev parent reply other threads:[~2007-04-21 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 9:32 Possible bug in --short option of git-rev-list Marco Costalba
2007-04-21 9:34 ` Junio C Hamano
2007-04-21 10:03 ` Marco Costalba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550704210303u195c6c3cub0df34b5e862a0c5@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).