From: "Marco Costalba" <mcostalba@gmail.com>
To: "Linus Torvalds" <torvalds@osdl.org>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <junkio@cox.net>,
"Alex Riesen" <raa.lkml@gmail.com>,
"Shawn Pearce" <spearce@spearce.org>
Subject: Re: [RFC \ WISH] Add -o option to git-rev-list
Date: Mon, 11 Dec 2006 19:59:22 +0100 [thread overview]
Message-ID: <e5bfff550612111059g35f1aa2dmdead17a60f5dfca8@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0612111003140.12500@woody.osdl.org>
On 12/11/06, Linus Torvalds <torvalds@osdl.org> wrote:
>
>
>
> However, you seem to continually ignore the thing I've asked you to do
> several times: try with a cold-cache situation.
Yes. I will test it. I was testing with warm cache also to my
curiosity about comparing pipes with temporary file reading as data
exchange facility. So I needed to avoid HD artifacts.
>
>
> At that point, you'd actually do something that gitk can't do at all,
> namely work well for the cold-cache not-very-packed large-repository
> case. ]
>
Removing --topo-order from launch parameters is very simple, see from
gitstartup.cpp:
bool Git::startRevList(SCRef args, FileHistory* fh) {
QString initCmd("git rev-list --header --boundary --parents ");
if (!isMainHistory(fh)) {
// fetch history from all branches so any revision in
// main view that changes the file is always found
SCRef allBranches = getAllRefSha(BRANCH).join(" ");
initCmd.append("--remove-empty " + allBranches + " -- ");
} else
initCmd.append("--topo-order ");
return startParseProc(initCmd + args, fh);
}
It is already removed from file history fetching because there the
history it's _almost_ linear and you gain the speed without noticing
the different graph layout. But for main view I fear that complicated
branch structures could became difficult to follow without
--topo-order. Perhaps an option in settings?
> To see this in practice (even with hot-caches), do something like the
> following on the full historic Linux archive:
>
> time sh -c "git rev-list HEAD | head"
> time sh -c "git rev-list --topo-order HEAD | head"
>
> where for me, the firstone takes 0.002s, and the second one takes 0.878s.
>
This is the data:
$ pwd
/git/linux-2.6
bash-3.1$ time sh -c "git rev-list HEAD | head"
200d018eff4be3a1fb9823441cfcebb7de86a677
f0647a52974daccbe20990fb6341f07792445fe0
c25c79d80e02db1bd993426f979c5f1b42a0f132
9fd32cfbb602f3e5e898faa61d83c4a7897bd48a
ed99e2bc1dc5dc54eb5a019f4975562dbef20103
773ff78838ca3c07245e45c06235e0baaa5f710a
52ffe760ea9ec407292d093c3f06c1cda5187228
14b36af46a1d3652aff6734ea24816995dff8123
eb991b39385c7b04923d701764a34694ec54b53d
88032b322a38b37335c8cb2e3473a45c81d280eb
0.08user 0.02system 0:00.10elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+3631minor)pagefaults 0swaps
bash-3.1$ time sh -c "git rev-list --topo-order HEAD | head"
200d018eff4be3a1fb9823441cfcebb7de86a677
f0647a52974daccbe20990fb6341f07792445fe0
c25c79d80e02db1bd993426f979c5f1b42a0f132
9fd32cfbb602f3e5e898faa61d83c4a7897bd48a
ed99e2bc1dc5dc54eb5a019f4975562dbef20103
773ff78838ca3c07245e45c06235e0baaa5f710a
52ffe760ea9ec407292d093c3f06c1cda5187228
14b36af46a1d3652aff6734ea24816995dff8123
eb991b39385c7b04923d701764a34694ec54b53d
33ec32fae0e2c4433bfd1e74cbde6cb16604a719
2.84user 0.12system 0:03.05elapsed 97%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+12086minor)pagefaults 0swaps
Also the long awaited ;-)
$ time sh -c "git rev-list --header --boundary --parents --topo-order
HEAD | cat > /dev/null"
3.75user 0.55system 0:04.42elapsed 97%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+18822minor)pagefaults 0swaps
$ time sh -c "git rev-list --header --boundary --parents --topo-order
HEAD > /tmp/tmp.txt; cat /tmp/tmp.txt > /dev/null"
3.50user 0.30system 0:03.92elapsed 97%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+18800minor)pagefaults 0swaps
next prev parent reply other threads:[~2006-12-11 18:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 11:38 [RFC \ WISH] Add -o option to git-rev-list Marco Costalba
2006-12-10 14:54 ` Alex Riesen
2006-12-10 18:16 ` Linus Torvalds
2006-12-10 19:51 ` Marco Costalba
2006-12-10 20:00 ` globs in partial checkout? Michael S. Tsirkin
2006-12-10 20:13 ` Linus Torvalds
2006-12-10 21:07 ` Michael S. Tsirkin
2006-12-10 20:08 ` [RFC \ WISH] Add -o option to git-rev-list Linus Torvalds
2006-12-10 20:19 ` Linus Torvalds
2006-12-10 22:05 ` Marco Costalba
2006-12-10 22:09 ` Marco Costalba
2006-12-10 22:16 ` Linus Torvalds
2006-12-10 22:35 ` Marco Costalba
2006-12-10 22:53 ` Linus Torvalds
2006-12-11 0:15 ` Marco Costalba
2006-12-11 0:51 ` Linus Torvalds
2006-12-11 7:17 ` Marco Costalba
2006-12-11 10:00 ` Alex Riesen
2006-12-11 16:59 ` Linus Torvalds
2006-12-11 17:07 ` Linus Torvalds
2006-12-11 17:39 ` Marco Costalba
2006-12-11 18:15 ` Linus Torvalds
2006-12-11 18:59 ` Marco Costalba [this message]
2006-12-11 19:25 ` Linus Torvalds
2006-12-11 20:28 ` Josef Weidendorfer
2006-12-11 20:40 ` Linus Torvalds
2006-12-11 20:54 ` Josef Weidendorfer
2006-12-11 21:14 ` Linus Torvalds
2006-12-15 18:45 ` Marco Costalba
2006-12-15 19:20 ` Linus Torvalds
2006-12-15 20:41 ` Marco Costalba
2006-12-15 21:04 ` Marco Costalba
2006-12-11 9:26 ` Josef Weidendorfer
2006-12-11 12:52 ` Marco Costalba
2006-12-11 13:28 ` Josef Weidendorfer
2006-12-11 17:28 ` Marco Costalba
2006-12-11 11:39 ` Andreas Ericsson
2006-12-11 12:59 ` Marco Costalba
2006-12-11 13:40 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550612111059g35f1aa2dmdead17a60f5dfca8@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
--cc=spearce@spearce.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).