git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthias Baumgarten <matthias.baumgarten@aixigo.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Alex Henrie <alexhenrie24@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Git List Mailing <git@vger.kernel.org>
Subject: Re: [PATCH v2] pull: introduce --merge option
Date: Wed, 28 Jul 2021 20:18:07 +0200	[thread overview]
Message-ID: <e5952eea-61f2-1beb-64a2-1a077c57f0e6@aixigo.com> (raw)
In-Reply-To: <xmqqv94u9x2l.fsf@gitster.g>

On 7/28/21 7:18 PM, Junio C Hamano wrote:
> I am afraid that you are misinterpreting what I said, comparing
> apples and oranges, and drawing a wrong conclusion >
> When I said "-m" would not fly well as a short-hand for "--merge" in
> the context of "pull", I didn't mean "nobody would think 'm' stands
> for 'merge'", and I didn't mean "more people would think 'm' stands
> for 'message' more than 'merge'".  The reason why I find it
> problematic is because it can be ambiguous >
> When we step back and think about your "switch -m" and its synonym
> "checkout -m", we realize that these commands fundamentally never
> take "--message", as there is no place to record such a message
> (they do not create a commit after all), after they switch to a
> different branch while carrying the local modification forward by
> performing a (possibly conflicting) content-level merge.  That is
> why we can give their "merge" operation a short-and-sweet "m"
> without confusing our users.  So contrasting "switch" having "-m"
> that means "merge" with "pull" that can conceivably take both
> "merge" and "message" is not a comparison you can draw useful
> conclusion from.
I must confess that this comparison is indeed not a valid one. Maybe -m 
isn't as great as I thought it was.

-- 
aixigo AG
Karl-Friedrich-Str. 68, 52072 Aachen, Germany
phone: +49 (0)241 559709-390, fax: +49 (0)241 559709-99
email: matthias.baumgarten@aixigo.com
web: https://www.aixigo.com
District Court Aachen – HRB 8057
Board: Christian Friedrich, Tobias Haustein
Chairman of the Supervisory Board: Dr. Roland Schlager

  reply	other threads:[~2021-07-28 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 13:46 [PATCH v2] pull: introduce --merge option Felipe Contreras
2021-07-21 17:06 ` Linus Torvalds
2021-07-21 17:11   ` Junio C Hamano
2021-07-26  4:06     ` Alex Henrie
2021-07-27  2:56       ` Felipe Contreras
2021-07-27  8:45       ` Junio C Hamano
2021-07-27 15:52         ` Alex Henrie
2021-07-27 16:48           ` Felipe Contreras
2021-07-28  7:44             ` Matthias Baumgarten
2021-07-28 17:18               ` Junio C Hamano
2021-07-28 18:18                 ` Matthias Baumgarten [this message]
2021-07-28 19:25                 ` Felipe Contreras
2021-07-27  6:31     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5952eea-61f2-1beb-64a2-1a077c57f0e6@aixigo.com \
    --to=matthias.baumgarten@aixigo.com \
    --cc=alexhenrie24@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).